[D6] Twitter Embedded Timeline

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2092233

Project 2: https://drupal.org/node/1992586

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjcarballo2092013git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Manual Review

This module worked when I installed it in a fresh drupal instance. There are a few things:

1. Variables should be cleaned up in hook_uninstall (in .install file). Use variable_del to clean up all variables the module creates.
2. It is not great practice to include javascript in the template files. They should be added, where appropriate, using drupal_add_js

All in all a good module.

- Small grammar/typing issues in README.txt:2, twitter_embedded_timeline_error.tpl.php:4, twitter_embedded_timeline.admin.inc:63, twitter_embedded_timeline.admin.inc:79, twitter_embedded_timeline.install:4
- function _twitter_embedded_timeline_validate_rgb_color($color) validates #00000 (with 5 zeroes) as correct, separately, which is confusing given the regex below. Note that most modern browsers (except IE 7 and older) can also use 3 characters color codes but this is not recommended
- there is no hook_install, and all variable_get() calls use only one parameter (twitter_embedded_timeline.admin.inc:22, twitter_embedded_timeline.admin.inc:32, twitter_embedded_timeline.admin.inc:96), there is no fallback, you can put null as second parameter
- widget works nicely, more variable_get() warnings in twitter_embedded_timeline.module:60~69

Correcting the link to repository

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.