[D7] Views Glossary

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxalinouman2173017git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi alinouman,

There are some errors 'Line exceeds 80 characters' in the following files
README.txt
views-exposed-form--views_gloss_temp.tpl.php

Your css problem can be resolved as :

Wrong Way

.views-glossary-module .view-content {
  float: right;
  width: 75%;}

It should be written as

.views-glossary-module .view-content {
  float: right;
  width: 75%;
}

Hi

As per coding standards for Drupal, line length should not be more than 80 characters. In README.txt, line # 3 and 8 are both more than 80, please correct that.

Thanks
Raman

Minor coding standard errors are not application blockers, please do a real manual review of the code.

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/README.txt
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 2 WARNING(S) AFFECTING 2 LINE(S)
  --------------------------------------------------------------------------------
   3 | WARNING | Line exceeds 80 characters; contains 118 characters
   8 | WARNING | Line exceeds 80 characters; contains 137 characters
  --------------------------------------------------------------------------------
  
  
  FILE: /home/klausi/pareview_temp/views-exposed-form--views_gloss_temp.tpl.php
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 3 WARNING(S) AFFECTING 3 LINE(S)
  --------------------------------------------------------------------------------
   13 | WARNING | Line exceeds 80 characters; contains 93 characters
   14 | WARNING | Line exceeds 80 characters; contains 88 characters
   16 | WARNING | Line exceeds 80 characters; contains 82 characters
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. views_glossary.js: should use 2 space indentation as defined in the javascript coding standards: https://drupal.org/node/172169 . Same for the curly braces style.
2. views_glossary_form_alter(): if you are targeting only one form you should use hook_form_FORM_ID_alter() instead.
3. $go_to_page .= '<span> of ' . $total_pages . ' (' . $total . ' TOTAL RECORDS)';: all user facing text must run through t() for translation and the variables should use placeholders with t().
4. Usability: Changing the form elements at the bottom does not do anything, there is no submit button to apply them?
5. "variable_get('views_glossary_name'),": all variables defined by your module need to be removed in hook_uninstall().
6. views-view--views_gloss_temp.tpl.php: why is that needed? Please add a comment at the top of the file. Same for views-view--views_gloss_temp.tpl.php.

Although you should definitely fix those issues they are not absolutely critical application blockers, so I guess this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to kscheirer as he might have time to take a final look at this.

no objections for more than a week, so ...

Thanks for your contribution, alinouman!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Closing this application as its been fixed & respective account has been updated

No need to do that, fixed issues will close automatically after 2 weeks. This gives interested parties time to reactivate the issue if they see a problem with the fix and also allows time to see that a change has been made. See https://drupal.org/node/156119