[D7] Workbench Access Hierarchical Select Section Assignment

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

There is still a master branch which should be deleted. See: https://drupal.org/node/1127732.

Did a manual review of the code and there is just one thing that I could see that is definitely very wrong.

You have listed as a dependency hs_smallhierarchy, but no such module exists. From your project page I suspect that you mean hierarchical_select instead.

Wasn't able to test the module for functionality as it could not be installed due to the dependency issue.

Ah, my bad. Didn't have hierarchical_select installed as I was just looking at the dependencies in the code. Perhaps you could update your project page dependency heading to just clarify that in case someone else gets confused like me.

I'll leave it for someone else to have a second look, but as far as I can see everything is in order.

Hi Pijus, nice job and thanks for contributing! The code checks out well. I'm a little confused though by the functionality of this because I'm not all that familiar with workbench access in the first place. I know other users will have more familiarity, but either way my suggestion is that you add more documentation/help text into the UI descriptions and readme file. Particularly if this project is intended to make the UI better, that seems to fit the bill. Second, you should format your git clone code correctly for the application page. Checkout a few other examples and you'll see that it shouldn't be user specific and should include http:// not @.

My one question is that if this is strictly intended to improve the workbench access UI, would it be more appropriate as a patch to WA itself that can then be rolled out in the newest version of workbench access? It could still run only if hierarchical_select is enabled. Again I'm not all that familiar with WA, but after running your module I wanted to share my reactions.

Thank you for you reviews. When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no major flaws). I think you only found minor coding standard issues in most cases, so if you are happy with the code otherwise you should set it to RTBC.

But otherwise looks RTBC to me. Assigning to kscheirer as he might have time to take a final look at this.

no objections for a week, so ...

Thanks for your contribution, pijus!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.