This module provides the support to create a responsive carousels using the Responsive Carousel jQuery plugin. It also supports the integration with the Views module and provides the API to create a responsive carousel for other modules.

Features

  • Provides the default integration with the Views module.
  • Provides the carousel pager by default.
  • Provides the API to use directly in the custom code.

Drupal Core version: 7.x

Visit the project page for the usage instructions.

The link to the project is, https://drupal.org/sandbox/th_tushar/2190995

The link to the GIT Repository is, git clone --branch 7.x-1.x th_tushar@git.drupal.org:sandbox/th_tushar/2190995.git

The direct link to the GIT Repository for non-maintainer, git clone --branch 7.x-1.x http://git.drupal.org/sandbox/th_tushar/2190995

Manual reviews of other projects:
https://drupal.org/comment/8461421#comment-8461421
https://drupal.org/comment/8461353#comment-8461353
https://drupal.org/comment/8461373#comment-8461373

Comments

th_tushar’s picture

th_tushar commented
Issue summary: View changes

Updated the issue summary.

th_tushar’s picture

th_tushar commented
Issue summary: View changes
PA robot’s picture

PA robot commented
Issue summary: View changes
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2191611

Project 2: https://drupal.org/node/2146489

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxth_tushar2190995git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

th_tushar’s picture

th_tushar commented
Issue summary: View changes
Status: Needs work » Needs review

The errors pointed by pareview.sh are towards the jquery library file, which cannot be changed or modified.

th_tushar’s picture

th_tushar commented
Issue summary: View changes
PA robot’s picture

PA robot commented
Issue summary: View changes
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2191611

Project 2: https://drupal.org/node/2146489

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

th_tushar’s picture

th_tushar commented
Issue summary: View changes
dave bagler’s picture

dave bagler commented
Status: Needs review » Needs work

I would recommend implementing hook_library() rather than including the three files separately in your jcarousel_responsive() function.

Then you could update your theme function to use drupal_add_library() to add your js and css files.

th_tushar’s picture

th_tushar commented
Status: Needs work » Needs review

Hi Dave Bagler,
Thank you very much for your review. It was very helpful, and I have made the changes as per your comment #9.

dave bagler’s picture

dave bagler commented

Just took a look, the hook_library change looks good.

malovanets’s picture

malovanets commented
Status: Needs review » Needs work

Hi

CSS issues:

1) Avoid using !important. Use nested classes instead
2) width: 20000em; is looking quite weird
3) Remove empty lines between style properties inside one block (selector)

in file jcarousel-responsive-view.tpl.php use

<?php foreach ($rows as $row): ?>

instead of

<?php foreach ($rows as $id => $row): ?>

since you are not using the $id anywhere

gobinathm’s picture

gobinathm
he/him
Primary language English
Location Milton, Ontario
commented

please update the project description to have non-maintainer GIT clone link

th_tushar’s picture

th_tushar commented
Issue summary: View changes
Status: Needs work » Needs review

Hi,
Thanks for your reviews, @malovanets and @gobinathm.

@malovanets,
Updated the CSS file to remove the empty lines and also corrected the jcarousel-responsive-view.tpl.php file to remove unused variable. Regarding the CSS code, the carousel is responsive and its the plugin's CSS.

@gobinathm,
Updated the project description with the non-maintainer GIT clone link.

Regards

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Postponed (maintainer needs more info)

https://drupal.org/project/jcarousel
https://drupal.org/node/1548484

This sounds like a feature that should live in the existing jcarousel project, there is already an active issue for it. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the jcarousel issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

th_tushar’s picture

th_tushar commented
Status: Postponed (maintainer needs more info) » Needs review

Hi klausi,
The plugin for responsive and non-responsive is different, and I have also tried to use that module, and integrate the responsive plugin in that module, but altogether, it doesn't work. I came across the same issue https://drupal.org/node/1548484, which made me build this module. When we try to use the responsive and non-responsive carousel on the same page, the UI of the page gets disturbed. If the theme is responsive, there is no need to install the https://drupal.org/project/jcarousel non-responsive module.
Also now-a-days, most of the website designs are responsive, and I hope this module will be very helpful to the community.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Postponed (maintainer needs more info)

Why would you have a responsive and a non-responsive carousel on the same page? All carousels should be responsive, right? Why should the existing jcarousel module stay non-responsive? Just provide a patch to the existing module to make it responsive? There even is already a patch that seems to start that.

th_tushar’s picture

th_tushar commented

I mean, I tried to integrate the responsive plugin in the same module, but it didn't work. The released responsive javascript plugin is different from the available non-responsive plugin. Anyways, the patch has been provided for this.

PA robot’s picture

PA robot commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2191611

Project 2: https://drupal.org/node/2146489

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Related issues: +#2146489: [D7] Credit Card on Delivery for Ubercart