[D7] Zoho SalesIQ

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxzoholivedesk2237609git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

PAReview checks out. All clear.

Project page looks good. All other items on standard checklist seem good.

Module is looking fine to me except fwe things :-

1. I think, there is no need to use hook_install() in .install file as we can use variable_get('variable_name', 'default_value'). So please remove this.

2. In system settings form, you have mark the "widget code field" required, so there is no need to write the validation handler for this. So please remove this.

thanks.

Line # 8 in livedesk.admin.inc, the function livedesk_admin_settings_form() is not a hook, so

/**
 * Implements hook_admin_settings().
 */ 

is incorrect, rather change it something like below

/**
 * Form builder function for module settings.
 */

Also please review other projects to get review bonus, as applications with review bonus would get more priority than normal applications.

Hi @zoholivedesk, I've reviewed your module.

1) I would recommend renaming your project "Livedesk" as opposed to "Zoho Livedesk," as this is the naming convention your code follows.

Save for the above nitpick, your code passes all sniffs I have installed via phpcs --Drupal, as well as an eyeball inspection.

Functionality is perfect - the module installed, I created an acct, and it worked flawlessly.

Installation is quite easy, works fine. However there is no license notificatin in your php files headers and README.txt is not composed in the standard template of readme for modules.
Everything else seems to be perfect.

PHP files should not have any licensing headers, drupal.org packaging automatically adds a LICENSE.txt file. The README style is surely not an application blocker, any other problems you found?

Well, in that case just readme file should be updated. No other problems found.

PAReview: Individual user account

It seems you are using a non-individual account.
All user accounts are for individuals. Accounts created for more than one user or those using anonymous mail services will be blocked when discovered (see Get a Drupal.org account).
Please note that organization accounts cannot be approved for git commit access. See https://drupal.org/node/1966218 and https://drupal.org/node/1863498 for details on what is/isn't allowed. Please update your user profile so that we don't have to assume that this is a group account.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

If this was the only issue than you need only to wait for the administrators to review your application.

You can make this process faster if you apply for Review bonus.
More about this here: https://www.drupal.org/node/1975228

Hi vigneshwaran,

you should add a module configure link in *.info file, so that a user can quickly reach at module configuration page from modules list.
configure = admin/config/system/zohosalesiq

Otherwise module work for me.

Hello Babusaheb,

The module configure link is already in zohosalesiq.info

Bumping to critical

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

The account is for an individual working for the Zoho company, but they have explicitly made clear their individual identity.

No duplication

No: Causes module duplication and/or fragmentation.

There is an identical module that, admittedly is harder to set up. It works though. here is the link --> LINK. It even has the same short name... :(

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements

Coding style & Drupal API usage

1. Looks good to me!

This review uses the Project Application Review Template.

I will update your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go the dedicated reviewer(s) as well.