Weibo Autopost

Some initial comments with a superficial review:

You should change the URI on the first post to the public URI: git clone http://git.drupal.org/sandbox/xenyo/1447074.git weibo_autopost

Manual review

You must delete all variables set by your module on hook_uninstall.
You are using 'und' variables, that are used only if the language is undetermined, you can use the function I post below instead to get the values of current language:

$weibo_body = field_get_items('node', $form_state, 'summary');

Automate review

You can find an automate code review from Drupal Code Sniffer here. I paste here the resume and attach the errors log.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• ./weibo_post.admin.inc: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function weibo_log_overview() {
  

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Greets!

Ummmmm, I think that field_get_items would not be used on a form context, so maybe you must look for other solution there.

We had those cases several time, a good solution would be to provide us the access data for a testaccount, if possible.

I think you can have a talk with this module SinaWeibo, both use weibo.com service.

Yes, check the Review bonus to speed your review.

Sorry for the delay, but you have not listed any reviews of other project applications in your issue summary as strongly recommended in the application documentation.

Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

1. SinaOpenApi.php appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms. The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.
2. weibo_post_uninstall(): doc block is wrong, see http://drupal.org/node/1354#hookimpl , same on other hook implementations.
3. "'#description' => t('.'),": empty description, so remove it.
4. weibo_post_log_overview(): do not create image markup yourself, use theme('image', ...) instead.
5. weibo_post_log_overview(): the third party returned text has to be considered as user provided input and has to be sanitized in order to avoid XSS exploits. Please see http://drupal.org/node/28984 . Or has it been sanitized along the way somewhere?

Hi,

Is this module supported in Drupal 6? thanks.

" so we need you to review other project applications .."

@xenyo: two reviews you've made are just links to ventral.org, and one is request for better issue description although information you ask is given in first comment. in general, manual in-depth reviews are expected of you.

Manual review

It is confusing that you named your module weibo_autopost, but
file names and module prefix is weibo_post. I'm not sure whether
you're required to fix this for approval but I think you should.

Documentation

Read http://drupal.org/node/161085 for a documentation guidelines. You
should:

• Clean README.txt of HTML markup. Structure content. See examples
  under "Style" here http://drupal.org/node/447604.
• Implement hook_help().
• Document all functions using Doxygen comment style and other Drupal
  requirements:
  • There is no such hook_form_submit(). weibo_post_submit() is a
    submit handler.
  • weibo_post_listing() and weibo_post_log_overview() need @return
    keyword.
  • weibo_post_uninstall() is implementation of hook_uninstall().

Code

It is generally a bad design decision to use global variables. Also,
there is no need to use global $_upload_params. Node form keys are
assigned to $node object as fields and are available for you in
hook_node_insert() and hook_node_update().

weibo_post_node_insert() and weibo_post_node_update() differs in one
line only. You should refactor this into separate general function.

Check if (empty($language)) { in weibo_post_submit()
always succeeds. There is no $language defined.

You are checking for field_image and field_logo. This is not user
friendly and makes assumptions that won't hold for a majority of node
types in real world. You should make image field configurable.

Also, there will be no need for ugly and wrong access of
$form['field'][$language][0]['#file'] once you move this code to
hook_node_insert(), hook_node_update() and use field_get_items() as
Maxorete suggested.

Removing review bonus tag, you have not done any manual review, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects.

Also, when finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no flaws).

Thanks for your reviews. when finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no flaws).

manual review:

1. weibo_autopost_uninstall(): this is a hook implementation and should be documented as such. See http://drupal.org/node/1354#hookimpl
2. "t('Connect your account ') . $weibo_connect_link;": do not concatenate translatable strings and variables, use placeholders with t() instead.
3. "&& !empty($node->weibo_autopost_enable) ? ($node->weibo_autopost_enable == 1) : 0" is the same as "&& !empty($node->weibo_autopost_enable)"?
4. weibo_autopost_node_presave(): use url() to create the node URL, then you don't need the global base_url.
5. weibo_autopost_node_presave(): global $_upload_params; is never used, remove it.
6. weibo_autopost_listing(): use check_url() instead of check_plain() to validate the image URL.
7. "theme_image($variables);": do not hardcode this theme function use theme('image', ...) instead.
8. weibo_autopost_associate_form(): this is not a hook implementation? See http://drupal.org/node/1354#forms on how to document form generating functions.
9. "'#title' => t($content_type->type),": you are using the machine name here, so this is not vulnerable to XSS exploits. However, if you should ever decide to use the name of the node type you will have to sanitize it (see http://drupal.org/node/28984 )

Although you should definitively fix those issues, they are no blockers so I think this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Thanks for your contribution and welcome to the community of project contributors on drupal.org!

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.