Closed (fixed)
Project:
Bootstrap
Version:
7.x-2.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Oct 2012 at 20:38 UTC
Updated:
23 Aug 2015 at 20:22 UTC
Jump to comment: Most recent
Comments
Comment #1
natted commentedI think the rename could be worthwhile.
This project has the most visibility, so if we can rename, it might make more sense? Although, what happens to the old project page?
Comment #2
natted commentedJust linking to @andregriffin's post stating:
http://drupal.org/node/1778574#comment-6696966
If this goes ahead, new project page would be:
http://drupal.org/project/bootstrap_framework
Comment #3
natted commentedComment #4
andregriffin commentedThe initial commit of the 2.x branch has been made, and the maintainers have been added. So we could move the open issues and mark this page as dead as soon as the maintainers get their git repositories pointed to the new project.
http://drupal.org/project/bootstrap_framework
Comment #5
wundo commentedWell, I don't agree with creating a new project, specially when instead of forking this repo you just copied the source code over and created a new one destroying all the commit history.
Marking as won't fix.
Comment #6
wundo commentedActually, won't fix is not a proper status for this, as I agree with name change, I just don't agree how the change itself was made (i.e. creating a new project, losing git history and removing original contributors git access).
Comment #7
andregriffin commentedComment #8
wundo commentedWhat about http://drupal.org/node/1798166 which yourself mentioned in the issue description?
Comment #9
andregriffin commentedAh, fantastic. I seem to have had the wrong "rename project" documentation bookmarked, which didn't mention that was possible. I should have referenced my initial research, so that's my fault. Luckily, that's an easy fix. I'd be appreciative if you could run those commands, otherwise I will try that early this week when I'm available.
Thanks again, and sorry for the confusion.
Comment #10
wundo commentedLooks like the bootstrap namespace is not used, what about moving to bootstrap?
Comment #11
andregriffin commentedI assume you mean http://drupal.org/project/bootstrap
If you want to petition an admin to delete the defunct project, then we can do that. But for the sake of moving things along quickly, I made Bootstrap Framework. I think it is an equally acceptable, and perhaps a little less ambiguous (as not to be confused with Drupal's use of the term "bootstrap", as used in the defunct module), and served the task of simply removing "twitter" from the branding.
Comment #12
wundo commentedAndre I think is really worth waiting, I have a quick chat on #drupal-contribute and they asked to wait another week.
IMO is worth waiting, bootstrap is a way better namespace. :)
#1837834: Offering to maintain Bootstrap
Comment #13
andregriffin commentedSure. If that's what's important, we will wait another week.
Comment #14
natted commentedHi @wundo.
Are you maintainer then? Or co-maintainer?
Gaining the namespace /project/bootstrap would be nice but if it's going to add a long wait, I'd rather we just move ahead.
Is there any way I can gain access to commit patches in order to improve the 2.x-dev branch?
Comment #15
cweagans/project/bootstrap now belongs to wundo, so this is unblocked.
Comment #16
wundo commentedcweagans, thanks for the quick response! :)
natted, I'm a co-maintainer. I will grant you commit access in the new project, don't worry, just let me go through the project migration first.
Comment #17
wundo commentedI've contacted by e-mail all co-maintainers and a few key contributors too letting them know about this issue and that the project namespace will be changed soon.
Comment #18
wundo commentedThe repository (and full history) is now available at git.drupal.org:project/bootstrap.git, I've also cloned the 7.x-2.0-beta1 release.
Everyone who had access to the repo before (plus natted) have access to the new repo.
Comment #19
wundo commentedWe have an open question, how do we let the users know they should move over to bootstrap?
Comment #20
wundo commented> We have an open question, how do we let the users know they should move over to bootstrap?
What about creating a new beta2 release with all the committed changes and letting them know in the Release notes that they should update to the new theme?
Maybe inserting a drupal message on every admin page?
Comment #21
natted commentedI think your suggestion with the new release would work. Anyone reviewing available updates would see the new version (beta2) eventually. It is most likely they would visit the twitter_bootstrap project page (which I guess we will update to explain the move so that they can't miss it).
The Drupal message is probably a good idea as well, in case anyone installs / updates via drush or some other method.
Some people may miss the change initially but most people would be covered.
Comment #22
natted commentedAlso, once everything is ready, if we re-assign all the issues (like Andre did earlier), anyone who has bookmarked an issue should reach the new project issue tracker.
Anyone following any twitter_bootstrap issues on drupal.org will get the (new) notification appear as well, so it'll be hard to miss for any active contributors.
Comment #23
frankbaele commentedI think we should just change the status of the theme to "no further development" & "unsupported" and refer to the new theme in the project description.
Comment #24
gagarine commentedYep fine for me.
FYI http://antistatique.net just worked some days on creating a new boostrap theme based on mothership. I will release it as a new branch on http://drupal.org/project/bootstrap when we feel comfortable to do so.
Comment #25
natted commented@frank probably a good idea also.
I have a feeling if the project gets marked "obsolete" then it adds a security notification within Drupal's update system. I may be wrong though.
Comment #26
gagarine commented@natted the project do have security issues... anyway people shouldn't use unstable version in production.
Comment #27
andregriffin commentedThere should have been no production uses at the time anyway, but since a beta was released for some reason, that is now something to consider. However, I think for many users of this theme, "upgrading" is probably not so important, as I think many users just use it as a starting point to build a custom theme with bootstrap. So marking the old page as obsolete and migrating the issue queue should be sufficient.
Comment #28
jcmiller09 commentedI just stumbled across the project with the new name, after setting up a site with the old one last week. Why don't you just add some text to the old twitter_bootstrap project page saying that it's deprecated/obsolete/changed since anyone might still link to that from blogs or just stumble across it. I didn't get any notifications with drush or in the site status page, so I was clueless.
Comment #29
natted commented@jcmiller - The changeover hasn't been completed yet, we will be doing as you suggest.
Comment #30
cweagansWhen everything has been moved over, you're welcome to ping me via my contact tab and I'll set up a redirect from twitter_bootstrap to bootstrap.
Comment #31
stephen ollmanWorks for me!
Comment #32
jcmiller09 commentedSounds like a plan. Keep up the good work.
Comment #33
natted commentedAs part of the move, I'll start re-assigning the open items in the issue queue.
I'll leave this one here, so others can see what's going on.
Comment #34
andregriffin commentedAll closed issues have now been re-assigned.
Comment #35
johnnyo commentedI was wondering if somebody could help. I have a subtheme of twitter bootstrap and have a website that has been working without any issues. I have upgraded the theme to the new bootstrap theme (without twittter) in the name. In my subtheme info file i have change the reference to bootstrap instead of twitter bootstrap. In my custom template.php file i have changed the references to bootstrap again instead of twitter bootstrap. Everything seems to be working apart from my menus. They do not render using the new bootstrap theme. I receive an error regarding $variables['tabs']['#primary'] = _twitter_bootstrap_local_tasks($variables['tabs']['#primary']); which i have changed to $variables['tabs']['#primary'] = _bootstrap_local_tasks($variables['tabs']['#primary']); to reference the menu.inc _bootstrap_local_tasks. Is there any issue with the menu.inc file in the new bootstrap theme? if i switch back to the twitter bootstrap theme and change the name references again it all works fine. I would like to be running the latest bootstrap theme but just cannot seem to get my menus to output.
Comment #36
markhalliwellDon't know why this is still open. It can be closed.
Comment #37
markhalliwell