This theme delivers all the power of amazing Twitter Bootstrap web framework directly to your Drupal site. It is lightweight, responsive and ready to use out of the box. And perfect for subtheming as well.

Features

  • Responsive design
  • Amazing navbar with integrated logo, search box and main menu
  • Elastic search box
  • Main menu with dropdowns, unlimited nesting, headers and delimiters
  • Affixed second sidebar region for table of contents, social plugins or something else
  • Adjusted styles of pager and polls
  • Perfect subtheming support

Screenshots

Tweme

Similar themes

Similar themes

Info

Reviews of other projects

Comments

Issue summary:View changes

Screenshot added.

Issue summary:View changes

Added download link.

Status:Needs review» Needs work

Looks cool!

You should create another branch called 7.x-1.x and set it to default. See http://drupal.org/node/1127732

Also check some warnings (code style, etc) at http://ventral.org/pareview/httpgitdrupalorgsandboxtonystar1825342git

And wait for a real review :)

Status:Needs work» Needs review

Thank you, netol!

Created 7.x-1.x branch. Still needs review of main functionality.

Status:Needs work» Needs review
StatusFileSize
new44.39 KB
new15.9 KB

HI,

Nice theme :)

Manual review:
1) RHS search bar is breaking
2) Drop down is not working
3) Give 5px space after button
( eg: go to blog page you can see two button save & cancel there is no space between two button. give 5px space between two buttons)

element.style {
   margin-right: 5px;
}

screenshot attached
please fix these issues

thanks
shanid kv

Status:Needs review» Needs work

Thank you shanidkv, I will fix that.

Status:Needs review» Needs work
StatusFileSize
new17.27 KB

Thank you shanidkv for your review!

I fixed and improved my theme according to your comments:

1) Added special search form box to the navbar instead search form block. You can see it after enabling Search module.
2) Dropdown is working now! With unlimited unlimited nesting, headers and delimiters ;)
3) Added 5px space beetween control buttons.

Status:Needs work» Needs review
StatusFileSize
new101.09 KB

Improved navbar, separated ScrollSpy and merged sidebars.

  • Refactored code according to standards.
  • Small fixes and enhancements.
  • Added search form to the navbar.
  • Added dropdown to the navbar.
  • Merged sidebars into one column.
  • Moved ScrollSpy navigation to the separate module (Tweme UI).

You can download it by the link below:

Issue summary:View changes

Updated download link.

Issue summary:View changes

Updated features and screenshot

Adding "PAReview: review bonus" tag.

Status:Needs review» Needs work
  • There are still some issues reported by the automatic project reviewer at http://ventral.org/pareview/httpgitdrupalorgsandboxtonystar1825342git
    after fixing the issues, you should probably repeat the automatic review yourself, until no issues remain there.
  • You have mentioned the JQuery Update module as a requirement in your README.txt file. so you should add a "dependencies[] = ..." line to your module's .info file. For more information on the contents of .info files, and the correct syntax for dependencies[], view this page: http://drupal.org/node/542202
    It is also not clear from the "jQuery 1.8.x" that it also refers to a drupal module (JQuery Update) that should be installed too.
    The links for your requirements have been also mistakenly substituted.
  • Although this is very minor, but step 4 in the installation instructions would be slightly better if the verb "Extract" was used instead of "Put".
  • About the theme itself, the search box has a nice sliding effect when it is focused. Could a similar effect be used for shrinking the search box on losing focus?

The rest of the theme looks fine to me. Keep up the good work!

Issue summary:View changes

Added Reviews of other projects section.

Thank you herom for comments, I will work on it.

Also removed PAReview: review bonus tag until all issues are fixed.

Hello herom,

1) I fixed all issues reported by the automatic project reviewer at http://ventral.org/pareview/httpgitdrupalorgsandboxtonystar1825342git-7x-1x
2) Unfortunately there is no way to add "dependencies[] = ..." to theme
3) I replaced "Put" with "Unpack" and then "Put"
4) I also added sliding effect on losing focus to search box.

Integrated with Libraries API, refactored navbar search and menu building.

* Integrated with Libraries API.
* Used native theme_menu_tree() and theme_menu_link() instead of custom functions for building navbar menu.
* Refactored navbar search form building to use Form API.
* Separated js for affixing second sidebar.
* Added sliding effect on losing focus on search box.
* Added right margin to the search box.
* Refactored code.
* Fixed issues obtained by Drupal Code Sniffer.
* Refactored `include_once` statement.
* Updated README.txt.

Status:Needs work» Needs review
Issue tags:+PAReview: review bonus
StatusFileSize
new23.63 KB
new13.56 KB

I totally refactored Tweme and made 3 manual reviews of other projects:

Please review my theme.

Issue summary:View changes

Removed Reviews of other projects until new version will be commited

AFAIK jQuery Update module cannot be configured to use jQuery 1.8.x

StatusFileSize
new7.31 KB

Actually it can be. See http://drupal.org/project/jquery_update for more details:

jQuery 1.8 with jQuery Update

Status:Needs review» Reviewed & tested by the community
Issue tags:-PAReview: review bonus
StatusFileSize
new1.85 KB

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

StatusFileSize
new2.73 KB

Thank you klausi for these great news!

And looking forward for the full project access.


I set the 7.x-1.x as default branch and removed the master branch.

Touching the Coder Sniffer results - I've already used the ":" alternative syntax instead of curly braces in template files. And for me Coder module don't notifies me about any warnings:

Coder results for Tweme

May be it was caused by missed semicolons after endif clauses?

Status:Reviewed & tested by the community» Needs work
Issue tags:+PAReview: security

Ooops, missed a security vulnerability.

tweme_menu_link__main_menu(): this is vulnerable to XSS exploits. If I have a main menu item with a title <script>alert('XSSmenu');</script> I get a nasty javascript popup on that page. You need to sanitize user provided input before printing if it has not been sanitized before. Please read http://drupal.org/node/28984 again.

Status:Needs work» Needs review
Issue tags:-PAReview: security

Removed XSS vulnerability.

I thought previously that menu link titles are always sanitized in preprocessors. I had to check their code.

Issue summary:View changes

Updated screenshots, added similar modules.

Issue tags:+PAReview: security

Please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Issue summary:View changes

Added review.

Status:Needs review» Reviewed & tested by the community

Cool, back to RTBC.

Just to speed up the process of full project application and to help you reviewing I made 3 extra reviews:

  1. http://drupal.org/node/1832562#comment-6717718
  2. http://drupal.org/node/1814020#comment-6717758
  3. http://drupal.org/node/1711898#comment-6717774

Thanks.

Issue summary:View changes

Added links to reviews.

As explained in #1819558: Explain that Drupal 7 version only supports 1.7.1 & 1.8.2 in dev snapshot, jQuery Update only updates jQuery to 1.8.2 in 7.x-2.x-dev, not in the current stable release 7.x-2.2. IMHO install instructions should be changed to reflect that.

StatusFileSize
new27.03 KB

drupal_render(drupal_get_form('_tweme_navbar_search_form') does a strict warning.

StatusFileSize
new55.36 KB
new80.78 KB

When the page is viewed as a mobile, the horizontal scroll bar appears, as there is some empty space on the right. It happens in desktop browsers, but also in mobile browsers.

Status:Reviewed & tested by the community» Needs work

Btw, I'm using Bootstrap 2.2.1. The live demo (http://tonystar.ru) is ok, so maybe this could be my fault.

Another minor issue is that by default, this is using the non-minified javascript file. Ideally this should be explained in README, as the user may want to rename bootstrap.min.js to bootstrap.js

Status:Needs work» Needs review

Thank you netol for your review.

> IMHO install instructions should be changed to reflect that.
I updated install instructions in README.txt, on the project page and on the home page: "Install the latest dev version of the jQuery Update module..."

> drupal_render(drupal_get_form('_tweme_navbar_search_form') does a strict warning.
Fixed this warning by separating the statement.

> When the page is viewed as a mobile, the horizontal scroll bar appears...
Can't reproduce that. Tested on desktop's Opera, FF, Chrome, IE, Safari and mobile's Safari and Chrome.

> Ideally this should be explained in README...
Added special note to the Configuration section in README.txt, on the project page and on the home page

Status:Needs review» Reviewed & tested by the community

Ok, let's see if I'm the only one that have that css issue.

Do yo plan to support multiple Bootstrap 2 versions? I think that 2.0 and 2.1 are quite different.

> Do yo plan to support multiple Bootstrap 2 versions? I think that 2.0 and 2.1 are quite different.
I've not planned to do that previously. But if many people will be interested - why not. Moreover 2.2 have just released.

Yes, Bootstrap 2.2.0 was released two weeks ago, but please don't claim that you support Bootstrap 2.x if it's not true.

Status:Reviewed & tested by the community» Fixed

Thanks for your contribution, tonystar!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Thank you for all the reviews and the full project promotion! I really appreciate it!

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

Added 3 more reviews.