Minor fixes for Navbar module in panopoly_admin.make

Adding to the queue. This requires a new module (breakpoints) so it will need a bit more testing.

Personally I don't like the way the navbar module is now heading into ... the old style wasn't perfect but reduced to the max.
The new way is too much functionality and loosing some of it's magic.

ditto that - am moving back to the older version... look forward to seeing things work again ;)

Ack! I hadn't seen this issue previously. Since its patch is out of date (there is now Navbar 1.0-alpha10) and my issue updates more dependencies that had new releases I'm going to mark this one as a duplicate of: #2028797: Update dependencies (admin_views, admin_menu) in panopoly_admin.make

If you want to go the other way, just let me know and I'll make a new patch here and remove Navbar from that other issue! :-)

Thanks,
David.

Actually, nevermind, I am going to go the other way and update the patch here. The navbar update is a difficult change (since there are still some bugs being shaken out in Drupal 8) and so it might increase the likelihood that my other patch will get committed if it's seperate. :-)

Attached is a new patch that upgrades all the way to navbar 1.0-alpha10 and correctly applies to the latest git 7.x-1.x branch.

Thanks much for the work here and the new navbar has been committed to -dev. To be honest, I don't like this design as much and having a couple extra module dependencies is pretty heavy, but best to be keeping up with the jonses.

I've been following Toolbar development in Drupal 8 and I think the dependencies are justified. They're necessary for making the accessibility code for Toolbar maintainable. Since it's how users will navigate the site, accessibility seems pretty important, and if it's a maintance nightmare that would make it less likely to be worked on...

Anywho, hopefully, the design can be easily modified in the theme layer!

Oh, and I forgot to add: Thanks! :-)

Ack, and one more note. Sorry for all the comments!

Navbar 1.0-alpha10 conflicts with Bootstrap-based themes. This has already been fixed in Toolbar in Drupal 8, but hasn't been backported to Navbar yet. This affects Open Atrium 2.0's default theme. So, we'll probably have to do one more update before Panopoly 1.0-rc5.

@dsnopek RC-5 is nearly here.

Do these 2 patches against alpha10?

https://drupal.org/node/1955912#comment-7377438
https://drupal.org/node/1757466#comment-7365576

The patch on the 2nd issue fixes the conflict, but it is NOT A BACKPORT of the fix in Drupal 8. We should wait for a backport because it affects how themes work with navbar. If I find the time, I can do it myself. How soon is Panopoly rc5?

I just create a patch on this issue: #1757466: Prefix all navbar classes to prevent theme clashes in comment #14 which backports the changes from the Drupal 8 toolbar. I hope this will get accepted upstream quickly, but if not, either Panopoly or Open Atrium will have to include this in their makefile.

Thanks! You're a champ. Let's hope for an alpha 11!

attached is a patch to the makefile so we can get this goodness in RC5 in case an alpha11 does not manifest in time.

Hrm, have you tested the patch against 1.0-alpha10? I was pretty sure it would only apply against the latest 7.x-1.x branch, but I haven't tried it.

This patch will need to apply against alpha 10 and I can put it in.

I also think it would be nice to have the dropdown happen on the left side by default (instead of on the top).

hm. patch doesn't apply against alpha10, only on dev.
@dsnopek, can you re-roll?

Secondarily, noticed that the navbar z-indexing overtakes the ctools modals. This is a bit of a show-stopper for Panopoly.
I opened an issue: #2050559: navbar z-index values conflict with ctools modals and have submitted a patch there. Likely, that patch will collide with the navbar class patch, though.
Not sure how to resolve that.

It's more than a re-roll - I'd have to include changes made in other revisions in 7.x-1.x in the patch. And if we're going to do that, we may as well put the most recent Git revision in the make file and then apply this patch to that.

Honestly, I think it'd be best waiting for Navbar 1.0-alpha11, which shouldn't be terribly long. There is one more major Toolbar patch (#1860434: Refactor the Toolbar JavaScript to use Backbone; fix several poorly functioning behaviors) waiting to get merged into Drupal 8, and then I imagine backporting everything to D7 and releasing will be the next natural step.

Does anyone know the timeline for Panopoly 1.0-rc5? Is it days away? Weeks away?

I can't believe I'm suggesting this :-) - but if Panopoly 1.0-rc5 is going to come out before Navbar 1.0-alpha11, we might be better off reverting to Navbar 1.0-alpha3 until -alpha11 comes out.

What do you guys think?

I was planning on rolling RC5 tomorrow for Panopoly.

I tried to apply the patch directly and it mostly applied, but had a few CSS conflicts (which may be a larger issue, didnt quite look). Is there a simple way to make Alpha 10 compatible and then we can revist for Navbar A11?

Heh, well, that's soon! What's the timeline for RC6? :-)

The simplest way would be to use the latest Git and add my patch for Bootstrap compat and @Andrew_Mallis's for CTools dialog compat. So, something like:

projects[navbar][version] = 1.x-dev
projects[navbar][type] = module
projects[navbar][download][type] = git
projects[navbar][download][revision] = 455f81d4d17051851fb5f425c653201c901a0338
projects[navbar][download][branch] = 7.x-1.x
projects[navbar][patch][1757466] = "http://drupal.org/files/navbar-conflict-1757466-14.patch"
projects[navbar][patch][2050559] = "http://drupal.org/files/z-index-heart-cools-2050559-1.patch"

But like I said, I think it'd be safer to revert to Navbar 1.0-alpha3 and wait until Panopoly 1.0-rc6 to do this upgrade when we have a more stable Navbar to work with... It's your call!

I chatted with Arshad a bit and figure we can just roll with -dev + the patch above. Alpha 11 can go in Panopoly 1.0.

Thanks, @populist! I'm updating my distros to work off of the latest Panopoly dev in Git and there are some minor problems with what's in there for Navbar now:

• Patches should use HTTP instead of HTTPS. On many systems, patches linked from https://drupal.org will fail.
• Added the patch to make the Navbar appear under CTools dialogs

New patch against the latest Git is attached!

Excellent. Committed.

Also, the https in the libraries need to be fixed. Will open a new issue for that.