[D7] ImageField EPS

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Provide the git clone details.

Added an example of where it's being used.

Hi apparently there is just a small issue with ventral.org :

FILE: /var/www/drupal-7-pareview/pareview_temp/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
47 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------------

also in imagefield_eps.module in function imagefield_eps_path_flush($uri)

 $target = drupal_realpath(file_build_uri('imagefield_eps_images')) . '/' . $filename;
  if (file_exists($target)) {
    unlink($target);
  }

may be changed with :

 $target = drupal_realpath(file_build_uri('imagefield_eps_images')) . '/' . $filename;
  if (file_exists($target)) {
     file_unmanaged_delete($image_path);
  }

somewhat like it's done in Image module

Problems preventing acceptance of the module:

• The Adobe color profiles that you included in your module fall under a different license than GPL 2+. Unfortunately, this will prevent this particular module from being hosted on drupal.org due to the licensing retrictions documented here.
• I get an error when uploading an EPS image into a custom node type as follows:
  

  PDOException: SQLSTATE[HY000]: General error: 1366 Incorrect integer value: '' for column 'field_eps_image_width' at row 1: INSERT INTO {field_data_field_eps_image} (entity_type, entity_id, revision_id, bundle, delta, language, field_eps_image_fid, field_eps_image_alt, field_eps_image_title, field_eps_image_width, field_eps_image_height) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7, :db_insert_placeholder_8, :db_insert_placeholder_9, :db_insert_placeholder_10); Array ( [:db_insert_placeholder_0] => node [:db_insert_placeholder_1] => 2 [:db_insert_placeholder_2] => 2 [:db_insert_placeholder_3] => mega_ultra_content_type [:db_insert_placeholder_4] => 0 [:db_insert_placeholder_5] => und [:db_insert_placeholder_6] => 1 [:db_insert_placeholder_7] => Dragon! [:db_insert_placeholder_8] => Dragon! [:db_insert_placeholder_9] => [:db_insert_placeholder_10] => ) in field_sql_storage_field_storage_write() (line 451 of C:\Users\Matt\workspace\drupal\modules\field\modules\field_sql_storage\field_sql_storage.module).

  It looks like the EPS is uploading properly, but the png is not being generated properly, and the module doesn't fail gracefully.
  Specifically, I'm running this on Windows 7 with GD 2.0.34 installed. Running the convert command directly (that is built on lines 173-175) gives the error "Invalid Parameter - -profile"

Other things that would be nice to fix/add:

• It would be nice to have a configurable file locaton for your converted pngs, rather than placing them all under 'imagefield_eps_images'
• When uninstalling the module, it leaves all of the uploaded and converted files in the sites/default/files directory. As you can't uninstall the module while any imagefield_eps field is in use, these files are unused at the time of uninstall and should probably be deleted.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

• You can remove the .gitignore file from the repo.
• If your module requires imagemagick, can you implement a hook_requirements() in your install file that checks for it?
• The constant NUM_COLORS should be namespaced to your module as IMAGEFIELD_EPS_NUM_COLORS.
• Consider the Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org. This would also let you ensure that the color profiles are properly included.

Namespace and missing requirements are blocking issues, but otherwise this would get RTBC from me. The module looks very useful.

----
Top Shelf Modules - Crafted, Curated, Contributed.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxel_toro1809344git

I'm a robot and this is an automated message from Project Applications Scraper.

Those are minor errors, robot :) Thanks for those updates el_toro.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Sorry for the delay, but you forgot to add the "PAReview: review bonus" tag and you did not do all manual reviews, sometimes you just provided the output of an automated review tool. I removed the automated reviews from the issue summary.

manual review:

1. the project page could be more clear. Does this module add a field type or a widget? What tool/library is used to perform EPS conversions? See also https://drupal.org/node/997024
2. imagefield_eps_image_conversion(): so you have to invoke exec() which might be disabled for security reasons on productions sites. That should also be mentioned on the project page.
3. imagefield_eps_image_conversion(): usually the file name is user provided and I assume it has been sanitized already by Drupal at this point? You should still use escapeshellarg() to be on the safe side here, so this is kind of a security blocker right now although I did not try to exploit it.

Cool, since this was otherwise RTBC already ...

Thanks for your contribution, el_toro!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.