Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
30 May 2013 at 12:17 UTC
Updated:
4 Jan 2014 at 03:28 UTC
Jump to comment: Most recent
Comments
Comment #1
nonzod commentedvery tiny module!
If you want to get the current path use "current_path" function instead of
Comment #2
ram4nd commented#1
current_path simply returns $_GET['q'], as that is not what I need. I can use it just instead of $_GET['q'], I will give it a thought.
Comment #3
Darth Raven commentedlanguage_switcher_fallback.module
Line 46:
Try not to use direct calls to theme(), use render arrays instead. They really improve Drupal theme flexibility.
Comment #4
ram4nd commentedFixed both #1 and #3. Thank you!
I also removed master branch and set 7.x-1.x branch to default branch.
Comment #5
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #5.0
PA robot commentedAdd lable for project page link.
Comment #5.1
ram4nd commentedAdded a review of a project for high priority list.
Comment #5.2
ram4nd commentedAdd branch to "Git repository".
Comment #5.3
ram4nd commentedAdd another review.
Comment #6
ram4nd commentedDid 3 manual reviews for "PAReview: review bonus". Also changed the modules description to be more accurate.
Comment #7
klausiReview of the 7.x-1.x branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
manual review:
But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.
Assigning to cubeinspire as he might have time to take a final look at this.
Comment #8
ram4nd commentedI fixed the sniffer problem, didn't know about that particular coding standard. I understand that it's a very small module, but I would appreciate if you would promote this single project manually to a full project for me. I will improve project page description, also I will create the README.txt. I will post here when I do, but i think it's not mandatory.
Comment #9
klausino objections for more than a week, so ...
Thanks for your contribution, ram4nd!
I promoted this project for you: https://drupal.org/project/language_switcher_fallback
Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #10.0
(not verified) commentedLast review.