Language Switcher Fallback module creates a language switcher block where untranslated pages link to frontpage instead of strikethroughed language name.

Links

Project page: http://drupal.org/sandbox/ram4nd/2002850
Git repository: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/ram4nd/2002850.git language_switcher_fallback

Reviews of other projects

https://drupal.org/node/2010506#comment-7492510
https://drupal.org/node/2011068#comment-7493664
https://drupal.org/node/2011366#comment-7495572

Comments

nonzod’s picture

very tiny module!
If you want to get the current path use "current_path" function instead of

$path = drupal_is_front_page() ? '<front>' : $_GET['q'];
ram4nd’s picture

#1
current_path simply returns $_GET['q'], as that is not what I need. I can use it just instead of $_GET['q'], I will give it a thought.

Darth Raven’s picture

Status: Needs review » Needs work

language_switcher_fallback.module
Line 46:

$block['content'] = theme('links__locale_block', $variables);

Try not to use direct calls to theme(), use render arrays instead. They really improve Drupal theme flexibility.

ram4nd’s picture

Status: Needs work » Needs review

Fixed both #1 and #3. Thank you!

I also removed master branch and set 7.x-1.x branch to default branch.

PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

Issue summary: View changes

Add lable for project page link.

ram4nd’s picture

Issue summary: View changes

Added a review of a project for high priority list.

ram4nd’s picture

Issue summary: View changes

Add branch to "Git repository".

ram4nd’s picture

Issue summary: View changes

Add another review.

ram4nd’s picture

Issue tags: +PAreview: review bonus

Did 3 manual reviews for "PAReview: review bonus". Also changed the modules description to be more accurate.

klausi’s picture

Assigned: Unassigned » cubeinspire
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus +PAreview: single application approval

Review of the 7.x-1.x branch:

  • README.txt is missing, see the guidelines for in-project documentation.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: /home/klausi/pareview_temp/language_switcher_fallback.module
    --------------------------------------------------------------------------------
    FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
    --------------------------------------------------------------------------------
     42 | WARNING | A comma should follow the last multiline array item. Found: )
    --------------------------------------------------------------------------------
    

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

  1. what is the use case of the module, what is it good for, why would I need it? Please explain on the project page. See also https://drupal.org/node/997024
  2. This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to cubeinspire as he might have time to take a final look at this.

ram4nd’s picture

I fixed the sniffer problem, didn't know about that particular coding standard. I understand that it's a very small module, but I would appreciate if you would promote this single project manually to a full project for me. I will improve project page description, also I will create the README.txt. I will post here when I do, but i think it's not mandatory.

klausi’s picture

Status: Reviewed & tested by the community » Fixed

no objections for more than a week, so ...

Thanks for your contribution, ram4nd!

I promoted this project for you: https://drupal.org/project/language_switcher_fallback

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Last review.