[D7] Tweet Poster

• Your application has to contain project page link.
• Fix issues by PAreview: http://ventral.org/pareview/httpgitdrupalorgsandboxitravindrasingh197073...
• If you use external libraries, then you can't include them. Use Libraries API for an example https://drupal.org/project/libraries
• Remove master branch and make 7.x-1.x: https://drupal.org/empty-git-master
• Version in info file is wrong. Also I don't think you need a separate project, if every module had their own project, then what would be the point of the at all.

Hi, i'm reviewed your project, in the file tweet_poster.module:

1. On line 42 replace 'access callback' => TRUE, because I am as an anonymous user access to adjustments. http://w3web.in/drupaltest/admin/config/services/tweet_poster
2. On line 126 you use return tweet_post_agrs($tweet_status, $image_fid); but the function tweet_post_agrs does not return anything, correct it. The same thing on the line 144: return twitterpage();.
3. On lines 151-154 replace require_once to module_load_include, and even better Use Libraries API

In the file tweet_poster.admin.inc:

• In function tweet_poster_admin use t() function. For example instead of
  

    $form['consumer_key'] = array(
      '#type' => 'textfield',
      '#title' => 'Twitter Consumer Key',
      '#default_value' => variable_get('consumer_key', NULL),
    );

  use the

    $form['consumer_key'] = array(
      '#type' => 'textfield',
      '#title' => t('Twitter Consumer Key'),
      '#default_value' => variable_get('consumer_key', NULL),
    );

And most importantly, rewrite your code to Drupal Coding Standards

Sorry for my english

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

Changing the priority to normal as stated in : https://drupal.org/node/539608

Also, please fix the error mentioned by zestagio, I can still access the http://w3web.in/drupaltest/admin/config/services/tweet_poster and can even change the API keys from there as an anonymous user. This is a security threat.

Overall, the module seems to be pretty promising and useful. I am looking forward for this module.

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/tweet_poster.admin.inc
  --------------------------------------------------------------------------------
  FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   36 | ERROR | Files must end in a single new line character
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. tweet_poster.module: why do you include tweet_poster_config.php in the global scope on every single page request? You should only include it when you actually need it, or does it contain hook implementations?
2. README.txt should mention where to get and install the library.
3. tweet_poster_callback_form(): this function is never used, or am I missing something?
4. You have quite a few exit calls, why do you need them? Note that drupal_goto() also calls exit. If you must use exit use drupal_exit() instead.
5. You are using the "@" operator quite in a few places to suppress PHP errors. You should not do that, and if you must there should be a comment.

I'm not sure about the security of the workflow with the unprotected menu paths, but I could also not come up with an idea how to exploit them, so I guess this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to jthorson as he might have time to take a final look at this.

no objections for a week, so ...

Thanks for your contribution, ravindrasingh!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2026039

Project 2: https://drupal.org/node/2011366

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.