[D7] Chitika Ads

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxbhobbs2013909git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Make the following changes in .module file

Use l() for generating links. i have seen many line you are using '#description' => '<p><a href="http://support.chitika.com/customer/portal/articles/62580-tracking-the-performance-of-each-ad-unit" target="_blank">What are Channels?</a></p>',

in .install file use in below given way for drupal 7

<?php
$result = db_select('table_name', 'c')
    ->fields('c')
    ->execute()
    ->fetchAssoc();
?>

instead of db_query("SELECT name FROM {variable} WHERE name LIKE 'chitika_ads\_ad\_block\_%'");

Hi, just reviewed your project:

Line 179: There is a typo in the permission name, so only user 1 can access the settings form. => "administer site configuration"

Nothing else from me here.

I was able to install and configure the module fine. But it does not show any version information which would make it impossible to track any changes.

Making this RTBC as the version information comes from d.o packaging script.

How can this be approved?

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Module seems good and useful I have tested and reviewed.

manual review:

1. chitika_ads_password: this variable should also be removed in hook_uninstall()?
2. chitika_ads_get_ad(): javascript should be added with drupal_add_js() or #attached in render arrays. Variables hsould be passed down from PHP to JS with Drupal-settings, see https://drupal.org/node/756722
3. chitika_ads_get_ad(): this is vulnerable to XSS exploits. If I enter a"; alert('XSS'); x = " as channel tracking I get a nasty javascript popup. You need to sanitize all user provided text before printing. Make sure to read https://drupal.org/node/28984 again. If you pass down the settings with Drupal.settings the strings get escaped properly. And please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

added "Review of other projects" section

I think drupal_add_js() only places the Javascript in the header or the footer. Since the div in chitika_ads_get_ad() has the chitika_ads-adspace class I thought the JS could attach whatever stuff to that.

But otherwise this looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to kscheirer as he might have time to take a final look at this.

added more reviews

I think you can still use drupal_add_js() to add the code inline, like in this example:
drupal_add_js('jQuery(document).ready(function () { alert("Hello!"); });', 'inline');

But the module looks nice and that's not a blocking issue.

Thanks for your contribution, bhobbs-chitika!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Congratulation for your first Drupal contribution keep it up, just a quick note

Installation
Installing and customization is easy and takes fewer than five minutes.

1. Upload `/chitika/` module directory to your drupal `/modules/` directory
2. Enable the Module `Chitika` through the `Modules` menu in Drupal

Modules always should go into sites/all/modules/ and not /modules/ which contain the core modules

Congratulation you got the full project access in drupal.org.

learn drupal 8 and prepare your module for D8 version too. good luck
@Ravin
http://w3web.in/Drupal-8-custom-module-development

more reviews