This module is an expansion of the already existing Mailchimp module.

Mailchimp offers no permissions system when you login, so everyone has access to any list or template. This module allows you to grant users access to specific lists and templates, and allows them to track campaign stats.

This module allows an administrator to assign Mailchimp lists and Mailchimp Templates to users.
From those lists users can create new campaigns, author emails, preview emails, send test emails and distribute the emails to any list they have been granted access.
After a campaign has been sent the user can review rudimentary campaign stats.

https://drupal.org/sandbox/jasonrichardsmith/1609114

git clone --branch 7.x-1.x jasonrichardsmith@git.drupal.org:sandbox/jasonrichardsmith/1609114.git mailchimp_user_list

Comments

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxjasonrichardsmith1609...

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

jasonrichardsmith@gmail.com’s picture

jasonrichardsmith@gmail.com commented
Status: Needs work » Needs review

Please review
all tests pass
Aside from this:
FILE: ...7-pareview/pareview_temp/includes/mailchimp_user_list.edit_campaign.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
67 | ERROR | Array indentation error, expected 6 spaces but found 0

Which I do not understand

dclavain’s picture

dclavain commented
Status: Needs review » Needs work

Hi jasonrichardsmith:

automated report

  • Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
  • FILE: ...-pareview/pareview_temp/includes/mailchimp_user_list.campaign_lists.inc
    --------------------------------------------------------------------------------
    FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
    --------------------------------------------------------------------------------
    54 | WARNING | Only string literals should be passed to t() where possible
    --------------------------------------------------------------------------------

    FILE: ...7-pareview/pareview_temp/includes/mailchimp_user_list.edit_campaign.inc
    --------------------------------------------------------------------------------
    FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
    --------------------------------------------------------------------------------
    67 | ERROR | Array indentation error, expected 6 spaces but found 0
    --------------------------------------------------------------------------------

Manual review

I have installed your module and it gives me the following notice:

  • Warning: Invalid argument supplied for foreach() in menu_unserialize() (line 400 of /home/drupal-custom-7/includes/menu.inc).
  • Warning: call_user_func_array() expects parameter 2 to be array, string given in _menu_item_localize() (line 701 of /home/drupal-custom-7/includes/menu.inc).
  • Notice: Undefined variable: user in mailchimp_user_list_export_members() (line 92 of /home/drupal-custom-7/sites/all/modules/contrib/mailchimp_user_list/includes/mailchimp_user_list.list_members.inc).
  • Notice: Trying to get property of non-object in mailchimp_user_list_export_members() (line 92 of /home/drupal-custom-7/sites/all/modules/contrib/mailchimp_user_list/includes/mailchimp_user_list.list_members.inc).
  • Notice: Undefined variable: q in mailchimp_user_list_export_members() (line 94 of /home/drupal-custom-7/sites/all/modules/contrib/mailchimp_user_list/includes/mailchimp_user_list.list_members.inc).
  • Notice: Trying to get property of non-object in mailchimp_user_list_export_members() (line 94 of /home/drupal-custom-7/sites/all/modules/contrib/mailchimp_user_list/includes/mailchimp_user_list.list_members.inc).
  • Warning: usort() expects parameter 1 to be array, null given in mailchimp_user_list_export_members() (line 126 of /home/drupal-custom-7/sites/all/modules/contrib/mailchimp_user_list/includes/mailchimp_user_list.list_members.inc).
  • Notice: Undefined variable: header in mailchimp_user_list_export_members() (line 128 of /home/drupal-custom-7/sites/all/modules/contrib/mailchimp_user_list/includes/mailchimp_user_list.list_members.inc).
  • Warning: Invalid argument supplied for foreach() in menu_unserialize() (line 400 of /home/drupal-custom-7/includes/menu.inc).
  • Warning: call_user_func_array() expects parameter 2 to be array, string given in _menu_item_localize() (line 701 of /home/drupal-custom-7/includes/menu.inc).
jasonrichardsmith@gmail.com’s picture

jasonrichardsmith@gmail.com commented
Status: Needs work » Needs review

For some reason I cannot get Drupal to display or log php errors. Not sure why. Probably an Ubuntu thing.

I will try from work.

I think I addressed all these problems.

One was 'title arguments' was not getting an array.

The mailchimp_user_list.list_members.inc was pretty self explanatory, force array before usort,
removed error return that did not apply in watchdog.

http://ventral.org/pareview/httpgitdrupalorgsandboxjasonrichardsmith1609...

Still getting that array indention error, not sure what it means.

dclavain’s picture

dclavain commented

Still getting that array indention error, not sure what it means.

    $form['mailchimp_tag_instructions'] = array(
      '#markup' => '<p>Use tags to load user data from the 
        mailing list, available tags are: ' . $mergetags,
      '#weight' => 6,
    );

see https://drupal.org/node/318#linelength

    $form['mailchimp_tag_instructions'] = array(
      '#markup' => '<p>Use tags to load user data from the mailing list, available tags are: ' . $mergetags,
      '#weight' => 6,
    );
jasonrichardsmith@gmail.com’s picture

jasonrichardsmith@gmail.com commented

Thanks!
Fixed
Pareview passes.

dclavain’s picture

dclavain commented
Status: Needs review » Needs work

Hi @jasonrichardsmith

I still have problems in mailchimp/members:

Fatal error: Cannot use object of type stdClass as array in /home/drupal-custom-7/sites/all/modules/contrib/mailchimp_user_list/includes/mailchimp_user_list.list_members.inc on line 109 

MailChimp MailChimp (mailchimp) Module  Enabled  7.x-2.10 
MailChimp MailChimp Activity (mailchimp_activity) Module  Not installed  7.x-2.10 
MailChimp MailChimp Campaigns (mailchimp_campaign) Module  Enabled 7.x-2.10 
MailChimp MailChimp Lists (mailchimp_lists) Module Enabled 7.x-2.10 
MailChimp MailChimp User List (mailchimp_user_list) Module  Enabled
jasonrichardsmith@gmail.com’s picture

jasonrichardsmith@gmail.com commented

should be fixed now, true added to json decode.
line 105 $obj = json_decode($buffer, TRUE);

jasonrichardsmith@gmail.com’s picture

jasonrichardsmith@gmail.com commented
Status: Needs work » Needs review

oops,

switched to needs review

jasonrichardsmith@gmail.com’s picture

jasonrichardsmith@gmail.com commented
Title: Mailchimp User List Module » [D7] Mailchimp User List Module

changed title

jasonrichardsmith@gmail.com’s picture

jasonrichardsmith@gmail.com commented
Priority: Normal » Major

Elevated after 2 weeks

PA robot’s picture

PA robot commented
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2009900

Project 2: https://drupal.org/node/2009846

Project 3: https://drupal.org/node/1388672

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

jasonrichardsmith@gmail.com’s picture

jasonrichardsmith@gmail.com commented
Priority: Major » Normal
Status: Needs review » Closed (duplicate)

closed as dupe for multiple projects.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Related issues: +#2009846: [D7] OMS Flexslider