This is a D6 module

This module was developed from the IMIS Auth Module, which uses a different SSO then IBC SSO and returns different data.

This module works with IBC SSO using SOAP. You will need to purchase the IMIS module from IBC for this to work. The developer of this module is in no way affiliated with IBC outside of being a customer.

This module works differently than the IMIS Authentication module

This module loads the following information from the SSO.
IMIS ID
Member Type
First Name
Last Name
Prefix
Suffix
Full Name
Company Name
Workphone

The IMIS admin can also attach "Extension Data" which can be any sort of user information query. This information is loaded into a long text field since we never know what it will return.

The SSO also returns information to create a cookie. If users are in the same domain they can access the IMIS web interface using this cookie. Then the cookie is destroyed on logout.

From original Auth module.
Exempt Users

Certain Drupal users can be exempted from iMIS Authentication (e.g. Drupal site admins). This permits their login, password and other behaviours to be handled normally by Drupal. These exempt users can be assigned to additional roles (e.g. content editors) as needed by administrators.

Why a seperate module
The IMIS Auth module uses a different web interface (REST) and is maintained by the people people that sell the IMIS module. I don't see them as having any interest in maintaining or integrating this service because it is a competing project.

git clone --branch master http://git.drupal.org/sandbox/jasonrichardsmith/1382482.git imis_ibc_authentication

Sandbox: http://drupal.org/sandbox/jasonrichardsmith/1382482

CommentFileSizeAuthor
#1 1382482_pareview.txt1.11 KBnatemow

Comments

natemow’s picture

Status: Needs review » Needs work
StatusFileSize
new1.11 KB

Automated review attached -- This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

Manual review -- having some familiarity with various iMIS integrations, I'd be happy to hit this one harder once the standardization stuff has been addressed.

jasonrichardsmith@gmail.com’s picture

Status: Needs work » Needs review

There were some commands found here:
http://drupal.org/node/1127732
That seemed to only apply to released modules. Could be wrong about that, still learning git.

I removed the License, added a README.txt, and created a new version off of master.
git clone --branch 6.x-1.x http://git.drupal.org/sandbox/jasonrichardsmith/1382482.git imis_ibc_authentication

jasonrichardsmith@gmail.com’s picture

Status: Needs review » Needs work

I ran the online version of pareview.sh and got the below. I will address and resubmit

------------------------------------------------------------------
There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 6.x-1.x branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards

sites/all/modules/pareview_temp/test_candidate/imis_ibc_auth.module:
 +173: [critical] Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.
 +437: [normal] Use db_query_range() instead of the SQL LIMIT clause

Status Messages:
 Coder found 1 projects, 1 files, 1 critical warnings, 1 normal warnings, 0 warnings were flagged to be ignored

FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 7 WARNING(S) AFFECTING 7 LINE(S)
--------------------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 120 characters
  5 | WARNING | Line exceeds 80 characters; contains 204 characters
 20 | WARNING | Line exceeds 80 characters; contains 188 characters
 22 | WARNING | Line exceeds 80 characters; contains 184 characters
 28 | WARNING | Line exceeds 80 characters; contains 285 characters
 32 | WARNING | Line exceeds 80 characters; contains 243 characters
 37 | WARNING | Line exceeds 80 characters; contains 106 characters
--------------------------------------------------------------------------------


FILE: ...eview/sites/all/modules/pareview_temp/test_candidate/imis_ibc_auth.info
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 5 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...ew/sites/all/modules/pareview_temp/test_candidate/imis_ibc_auth.install
--------------------------------------------------------------------------------
FOUND 33 ERROR(S) AND 5 WARNING(S) AFFECTING 34 LINE(S)
--------------------------------------------------------------------------------
   5 | ERROR   | The last line in the file doc comment must be " */"
   9 | WARNING | Format should be * Implements hook_foo().
  12 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
  12 | ERROR   | There must be no blank line following an inline comment
  13 | ERROR   | Whitespace found at end of line
  19 | WARNING | Format should be * Implements hook_foo().
  22 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
  25 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
  32 | WARNING | Format should be * Implements hook_foo().
  54 | ERROR   | Whitespace found at end of line
  55 | ERROR   | Whitespace found at end of line
  56 | ERROR   | Whitespace found at end of line
  61 | ERROR   | Whitespace found at end of line
  62 | ERROR   | Whitespace found at end of line
  63 | ERROR   | Whitespace found at end of line
  68 | ERROR   | Whitespace found at end of line
  69 | ERROR   | Whitespace found at end of line
  70 | ERROR   | Whitespace found at end of line
  75 | ERROR   | Whitespace found at end of line
  76 | ERROR   | Whitespace found at end of line
  81 | ERROR   | Whitespace found at end of line
  82 | ERROR   | Whitespace found at end of line
  87 | ERROR   | Whitespace found at end of line
  88 | ERROR   | Whitespace found at end of line
  89 | ERROR   | Whitespace found at end of line
  94 | ERROR   | Whitespace found at end of line
  95 | ERROR   | Whitespace found at end of line
 100 | ERROR   | Whitespace found at end of line
 101 | ERROR   | Whitespace found at end of line
 104 | WARNING | Line exceeds 80 characters; contains 89 characters
 104 | ERROR   | No space before comment text; expected "// .Extension data is
     |         | an optional query that can return anything from a user
     |         | account" but found "//.Extension data is an optional query
     |         | that can return anything from a user account"
 105 | WARNING | Line exceeds 80 characters; contains 88 characters
 105 | ERROR   | No space before comment text; expected "// Because we have no
     |         | idea what it will return I am loading it in a long text field"
     |         | but found "//Because we have no idea what it will return I am
     |         | loading it in a long text field"
 106 | ERROR   | No space before comment text; expected "// to be parsed by the
     |         | admin later" but found "//to be parsed by the admin later"
 106 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 110 | ERROR   | Whitespace found at end of line
 111 | ERROR   | Whitespace found at end of line
 126 | ERROR   | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...iew/sites/all/modules/pareview_temp/test_candidate/imis_ibc_auth.module
--------------------------------------------------------------------------------
FOUND 127 ERROR(S) AND 17 WARNING(S) AFFECTING 97 LINE(S)
--------------------------------------------------------------------------------
   4 | ERROR   | The second line in the file doc comment must be " * @file"
   6 | ERROR   | Missing function doc comment
  23 | ERROR   | No space before comment text; expected "// Location of WSDL
     |         | file" but found "//Location of WSDL file"
  23 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
  24 | ERROR   | An operator statement must be followed by a single space
  31 | WARNING | Line exceeds 80 characters; contains 123 characters
  31 | ERROR   | No space before comment text; expected "// This is required if
     |         | users need to ineract with the web interface.  This is easier
     |         | than trying to parse from the server." but found "//This is
     |         | required if users need to ineract with the web interface. 
     |         | This is easier than trying to parse from the server."
  32 | ERROR   | An operator statement must be followed by a single space
  47 | WARNING | A comma should follow the last multiline array item. Found: )
  89 | ERROR   | You must use "/**" style comments for a function comment
  91 | ERROR   | Expected "foreach (...) {\n"; found "foreach(...) {\n"
  93 | ERROR   | Concat operator must be surrounded by spaces
  94 | ERROR   | Concat operator must be surrounded by spaces
  97 | WARNING | Line exceeds 80 characters; contains 117 characters
  97 | ERROR   | Inline comments must start with a capital letter
  97 | ERROR   | Comments may not appear after statements.
 105 | ERROR   | No space before comment text; expected "// Check to make sure
     |         | its an actual WSDL url" but found "//Check to make sure its an
     |         | actual WSDL url"
 105 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 109 | ERROR   | Expected "if (...) {\n"; found "if (...){\n"
 113 | ERROR   | You must use "/**" style comments for a function comment
 114 | ERROR   | No space before comment text; expected "// since there is an
     |         | option to alter a menu (by disabling a local menu task)" but
     |         | found "//since there is an option to alter a menu (by
     |         | disabling a local menu task)"
 114 | ERROR   | Inline comments must start with a capital letter
 115 | ERROR   | No space before comment text; expected "// we need to rebuilt
     |         | the menu if that setting is changed" but found "//we need to
     |         | rebuilt the menu if that setting is changed"
 115 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 122 | WARNING | Format should be * Implements hook_foo().
 130 | ERROR   | Inline control structures are not allowed
 136 | ERROR   | No space before comment text; expected "// alter forms based
     |         | on type" but found "//alter forms based on type"
 136 | ERROR   | Inline comments must start with a capital letter
 136 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 140 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 150 | ERROR   | No space before comment text; expected "// disable password
     |         | links" but found "//disable password links"
 150 | ERROR   | Inline comments must start with a capital letter
 150 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 157 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 180 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 182 | ERROR   | Inline comments must start with a capital letter
 182 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 187 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 194 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 196 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 198 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 201 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 203 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 205 | WARNING | Line exceeds 80 characters; contains 81 characters
 205 | ERROR   | No space before comment text; expected "// if not add it to
     |         | the list to ensure site admin uses normal authentication" but
     |         | found "//if not add it to the list to ensure site admin uses
     |         | normal authentication"
 205 | ERROR   | Inline comments must start with a capital letter
 205 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 211 | WARNING | Line exceeds 80 characters; contains 89 characters
 217 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 220 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 225 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 227 | WARNING | Line exceeds 80 characters; contains 105 characters
 227 | ERROR   | No space before comment text; expected "// if the remote uid
     |         | exists in our database do a check to see if it matches the
     |         | user we loaded earlier" but found "//if the remote uid exists
     |         | in our database do a check to see if it matches the user we
     |         | loaded earlier"
 227 | ERROR   | Inline comments must start with a capital letter
 227 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 229 | ERROR   | Inline comments must start with a capital letter
 231 | ERROR   | No space before comment text; expected "// for some reason if
     |         | the login form is submitted from a block calling" but found
     |         | "//for some reason if the login form is submitted from a block
     |         | calling"
 232 | WARNING | Line exceeds 80 characters; contains 81 characters
 232 | ERROR   | No space before comment text; expected "// user_external_login
     |         | will work to do the additional validation of the user" but
     |         | found "//user_external_login will work to do the additional
     |         | validation of the user"
 233 | ERROR   | No space before comment text; expected "// however, if the
     |         | form is submitted from /user/login" but found "//however, if
     |         | the form is submitted from /user/login"
 234 | WARNING | Line exceeds 80 characters; contains 87 characters
 234 | ERROR   | No space before comment text; expected "// user_external_login
     |         | will go into an infinite loop as it re-loads the login form"
     |         | but found "//user_external_login will go into an infinite loop
     |         | as it re-loads the login form"
 235 | ERROR   | No space before comment text; expected "// As a work around -
     |         | we do the same checks from that function here." but found
     |         | "//As a work around - we do the same checks from that function
     |         | here."
 237 | ERROR   | A cast statement must be followed by a single space
 245 | WARNING | Line exceeds 80 characters; contains 115 characters
 246 | WARNING | Line exceeds 80 characters; contains 118 characters
 247 | WARNING | Line exceeds 80 characters; contains 119 characters
 247 | ERROR   | Whitespace found at end of line
 255 | ERROR   | No space before comment text; expected "// Set user email" but
     |         | found "//Set user email"
 255 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 258 | ERROR   | No space before comment text; expected "// Update user
     |         | information in IMIS ibc member table" but found "//Update user
     |         | information in IMIS ibc member table"
 258 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 269 | ERROR   | Whitespace found at end of line
 270 | ERROR   | Whitespace found at end of line
 271 | ERROR   | Whitespace found at end of line
 281 | ERROR   | No space before comment text; expected "// provide some
     |         | feedback for the user" but found "//provide some feedback for
     |         | the user"
 281 | ERROR   | Inline comments must start with a capital letter
 281 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 300 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 311 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 313 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 328 | ERROR   | Whitespace found at end of line
 331 | ERROR   | Whitespace found at end of line
 332 | ERROR   | Whitespace found at end of line
 342 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 345 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 346 | ERROR   | Concat operator must be surrounded by spaces
 346 | ERROR   | Concat operator must be surrounded by spaces
 364 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 372 | ERROR   | No space before comment text; expected "// Instantiate SOAP
     |         | client" but found "//Instantiate SOAP client"
 372 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 373 | ERROR   | Expected 1 space between "'trace'" and double arrow; 0 found
 373 | ERROR   | Expected 1 space between double arrow and "TRUE"; 0 found
 373 | ERROR   | Expected 1 space between "'connection_timeout'" and double
     |         | arrow; 0 found
 373 | ERROR   | Expected 1 space between double arrow and "'60'"; 0 found
 374 | ERROR   | No space before comment text; expected "// Log in" but found
     |         | "//Log in"
 374 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 376 | ERROR   | No space before comment text; expected "// Check for
     |         | successful login" but found "//Check for successful login"
 376 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 378 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 384 | ERROR   | No space before comment text; expected "// Set cookie for Imis
     |         | web pages this is for Imis web interface access" but found
     |         | "//Set cookie for Imis web pages this is for Imis web
     |         | interface access"
 384 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 386 | ERROR   | Space before opening parenthesis of function call prohibited
 394 | ERROR   | No space before comment text; expected "// Fetch Session Info"
     |         | but found "//Fetch Session Info"
 394 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 399 | WARNING | A comma should follow the last multiline array item. Found: 1
 402 | ERROR   | No space before comment text; expected "// Return error
     |         | message" but found "//Return error message"
 402 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 409 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 410 | ERROR   | Constants must be uppercase; expected RESULT but found result
 411 | ERROR   | Constants must be uppercase; expected PREFIX but found prefix
 412 | ERROR   | Constants must be uppercase; expected SUFFIX but found suffix
 413 | ERROR   | Constants must be uppercase; expected FIRSTNAME but found
     |         | firstname
 414 | ERROR   | Constants must be uppercase; expected LASTNAME but found
     |         | lastname
 415 | ERROR   | Constants must be uppercase; expected FULLNAME but found
     |         | fullname
 416 | ERROR   | Constants must be uppercase; expected PHONE but found phone
 417 | ERROR   | Constants must be uppercase; expected COMPANY but found
     |         | company
 418 | ERROR   | Constants must be uppercase; expected EMAIL but found email
 419 | ERROR   | Constants must be uppercase; expected MEMBERTYPE but found
     |         | membertype
 420 | ERROR   | Constants must be uppercase; expected IMISID but found imisid
 421 | ERROR   | No space before comment text; expected "// Extension data is
     |         | optional" but found "//Extension data is optional"
 421 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 422 | ERROR   | Constants must be uppercase; expected EXTENSION but found
     |         | extension
 424 | ERROR   | Whitespace found at end of line
 427 | WARNING | Format should be * Implements hook_foo().
 469 | WARNING | Line exceeds 80 characters; contains 92 characters
 469 | ERROR   | Line indented incorrectly; expected at least 10 spaces, found
     |         | 8
 469 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 470 | ERROR   | Line indented incorrectly; expected at least 10 spaces, found
     |         | 8
 474 | WARNING | Line exceeds 80 characters; contains 95 characters
 475 | ERROR   | No space before comment text; expected "// will talk to ibc to
     |         | about expanding the security on this" but found "//will talk
     |         | to ibc to about expanding the security on this"
 475 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 478 | ERROR   | Space before opening parenthesis of function call prohibited
 478 | ERROR   | No space found after comma in function call
 478 | ERROR   | No space found after comma in function call
 478 | ERROR   | No space found after comma in function call
 478 | ERROR   | No space found after comma in function call
 479 | ERROR   | Space before opening parenthesis of function call prohibited
 479 | ERROR   | No space found after comma in function call
 479 | ERROR   | No space found after comma in function call
 479 | ERROR   | No space found after comma in function call
 479 | ERROR   | No space found after comma in function call
 484 | WARNING | Format should be * Implements hook_foo().
 496 | ERROR   | No space found after comma in function call
--------------------------------------------------------------------------------

Source: http://ventral.org/pareview - PAReview.sh online service

jasonrichardsmith@gmail.com’s picture

Status: Needs work » Needs review

I have been wrestling with pareview but I think everything is taken care of.

git clone --branch 6.x-1.x http://git.drupal.org/sandbox/jasonrichardsmith/1382482.git imis_ibc_authentication

jasonrichardsmith@gmail.com’s picture

My code is clean and the security works. Still awaiting approval.

After talking with IBC I am instituting some further security measures.

jasonrichardsmith@gmail.com’s picture

Just ran this through coder

Added some more ibc functionality and this module is ready to go.

jasonrichardsmith@gmail.com’s picture

Priority: Normal » Major

changing to major after 2 weeks without review

klausi’s picture

Get a review bonus and we will come back to your application sooner.

jasonrichardsmith@gmail.com’s picture

Priority: Major » Critical

Moving to critical.

jasonrichardsmith@gmail.com’s picture

Was wondering if anyone could review? When I get home today, I will be reviewing other committed modules.

http://git.drupal.org/sandbox/jasonrichardsmith/1382482.git 6.x-1.1x
git clone --branch 6.x-1.1x http://git.drupal.org/sandbox/jasonrichardsmith/1382482.git imis_ibc_authentication

klausi’s picture

Priority: Critical » Normal
Status: Needs review » Needs work

Sorry for the delay, but you have not listed any reviews of other project applications in your issue summary as strongly recommended here: http://drupal.org/node/1011698

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732

manual review:

  • what branch should I review? 6.x-1.1x or 6.x-1.x? I would suggest to remove the confusing 6.x-1.1x branch (does not match the Druapl release branch naming pattern) and merge everything into 6.x-1.x.
klausi’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

jasonrichardsmith@gmail.com’s picture

Title: IMIS IBC Authentication » [D6]IMIS IBC Authentication
Status: Closed (won't fix) » Needs review

This module was closed for inactivity. Deleted old branches please review.

PA robot’s picture

Status: Needs review » Closed (duplicate)
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2009900

Project 2: https://drupal.org/node/2009846

Project 3: https://drupal.org/node/1388672

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

Issue summary: View changes

added sandbox link

avpaderno’s picture