[D7] Utility Image Rebuild

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2034575

Project 2: https://drupal.org/node/2035383

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Update the project desc.

Hi!

From my not expert point of view code seems to be correct. The only strange thing, that I noticed, was in README file. You wrote that there are 3 common cases of using the module, but in you project page you point only two of them. And it seems that the case 2 and case 3 (2?) should be combined into one, i.e. user should replace files manually and also replace uris in database, right?
And another one suggestion (but maybe it is not necessary). Maybe you could also put error message in watchdog?

Update reviews of other projects.

Much better now:)
English my second language too.

Thanks!

Update the project desc

"give it a sign off" what does it mean?
Language problems. sorry:)

Sure, no problems

manual review:

1. utility_image_rebuild.module: do not module_load_include() files in the global scope, include them in function bodies when you actually need them.
2. _utility_image_rebuild_process(): do not run check_plain() for DB query functions. check_plain() is only useful if you print stuff to the HTML response. Please read https://drupal.org/node/28984 again.
3. "$context['message'] = 'We are processing the file with fid - ' . $id;": all user facing text must run through t() for translation.
4. "watchdog('Utility Image Rebuild', ':message', array(':message' => $message), $severity);": the ":" placeholder does not exist for watchdog().

But otherwise this looks almost RTBC, knowing where to use check_plain() and where not is an application blocker. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

This is an interesting module. I don't see any errors in formatting or on pareview.sh, I'm not expert, but i don't see any blockers in the code either. I went ahead and made some language changes as a native English speaker (Good job though! There wasn't anything egregious :) ) and broke the dependencies into their own section in the README. These are all in the patch, it was easier than writing them all out here. I made no code changes.

None of these things are a blocker though so I'm not moving this back to needs work.

I'll let someone more experienced check the code changes in #12.

Update the review second round.

Looks RTBC to me now! Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to stBorchert as he might have time to take a final look at this.

Thanks for your contribution, Joseph!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.