[D7] Image Effects Kits

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxjaychen2052315git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello Jay.Chen!

Manual review is as follows:

.module lines 12,13:

  $drupal_module_path = drupal_get_path('module', 'iek');
  require_once $drupal_module_path . '/iek.gd.inc';

you can changed it to a "more direct call"

require_once realpath(__DIR__) . '/iek.gd.inc';

.module lines 286, 287, 302, 304, 331, 333 and 334

    $summary['border thick'] = $data['border_thick'] . t('px');
    $summary['padding'] = $data['padding'] . t('px');

    $summary['width'] = $data['width'] . t('px');
    $summary['height'] = $data['height'] . t('px');


    $summary['size'] = $data['size'] . t('px');
    $summary['angle'] = $data['angle'];
    $summary['x-ordinate'] = $data['x'] . t('px');
    $summary['y-ordinate'] = $data['y'] . t('px');

the t() call is not necessary. The px value will not be translated.

.module lines 300 and 318

$data = $variables['data'];
...
 if ($data['width'] && $data['height']) {
...
  if ($data['text']
    && $data['font']
    && $data['color']
    && $data['size']
    && $data['angle']
    && $data['x']
    && $data['y']) {

If the key text or another doens't exist, the php will create a notice. Evaluate use isset() istead

if (isset($variables['data'])) {
...
if (isset($data['width']) && isset($data['height'])) {
....

sorry I didn't change the status :(

Hi there, I like this module.

[general observation]
You've done well to apply the Drupal code standards thoroughly.

[manual review]
I get the following error when choosing certain fonts for a watermark effect:

Warning: imagettftext(): Could not find/open font in iek_gd_watermark() (line 491 of PATH/sites/all/modules/contrib/iek/iek.gd.inc).

To recreate:
On admin/config/media/image-styles/edit/iek_photo
I edited the default IEK - Watermark effect and select one of the following fonts:

• `Abduction`
• `Tuffy`
• `Tuffy Bold`

With the other fonts there is no problem. This is strange since these fonts are included in the `fonts` folder. Its worth a look if you can recreate it.

Hello @Jay.Chen

I found the cause. Change the following font file names to all-lower-case. This will solve the problem.

• Abduction.ttf to abduction.ttf
• Tuffy.ttf to tuffy.ttf
• Tuffy_Bold.ttf to tuffy_bold.ttf

I can't tell why this error wasn't happening when you tried. Either way this should solve the problem for other people who may download your module.

Cheers

Hello.

I have to correct one of the points of my review. Sorry. In the review process of a module of mine told me that instead utilizase module_load_include required, so I adopted that point as a correction to make.

My module has passed the review process, but the person who enabled the publication of the project (cweagans) commented as follows on the subject:

For this bit:

 389 /**
 390  * include the block functions file
 391  */
 392 require_once realpath(__DIR__) . '/pay_with_a_tweet.blocks.inc';
 393 
 394 /**
 395  * include the tokens functions file
 396  */
 397 require_once realpath(__DIR__) . '/pay_with_a_tweet.tokens.inc';

1) To load module include files, you should use module_load_include; and
2) If you're including this unconditionally, there's no reason to split them out into another file. It is, in fact, a bit slower, since you're adding a couple of disk reads/file open operations into the mix. You could probably just copy the contents of those files into your .module file and you'd be fine.

I understand that, in this case, it is better to follow the recommendation of a person who can enable publishing projects.

Woah.
Um, have you not seen Image(cache) Actions ? It's been doing all these things since Drupal4.
In a project application review, You must "Search for similar modules, and explain how your application is different.". I just have to google for drupal image effects and it's the top result.

Duplication

Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. If you believe your project contains features that are not already available in that project, Please open an issue in the Imagecache Actions issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward.

If that fails for whatever reason please get back to us and set this back to "needs review".

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2076185

Project 2: https://drupal.org/node/2052349

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.