[D7] Quick Update

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2076185

Project 2: https://drupal.org/node/2052349

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Problems:

1. quickupdate.module, function quickupdate_autocomplete_search_projects - please, use a placeholders for t() function.
2. quickupdate.module, function quickupdate_get_project - contains dublicate code.
3. quickupdate.module (line 16) - this is unnecessary code.
4. Screen - where is "Download these updates" button? (not founded in code).

Recommendations:

1. Will be great if module contains hooks for add to list of themes and modules other items.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Adds reviews of other projects.

• Doesn't drush already let you easily install or update multiple projects from the command line? It grabs dependencies as well, how does this differ?
• If you're going to clobber update's validate and submit functions, you can do it in one line with $form['#validate'] = array('quickupdate_manager_update_form_validate');

Looks like a useful module, nice work!

----
Top Shelf Modules - Crafted, Curated, Contributed.

I removed one automated review comment from the issue summary.

manual review:

1. quickupdate_install(): do not juggle with module weights, because that is not reliable. Use hook_module_implements_alter() instead fi you must run before/after a specific other hook implementation.
2. quickupdate_form_alter(): if you are only targeting one specific form you should use hook_form_FORM_ID_alter() instead.
3. "simplexml_load_file(UPDATE_DEFAULT_URL ...": This fail on many drupal installations because remote file inclusion is disabled for security reasons. Use drupal_http_request() instead.
4. quickupdate_get_project(): why the json_encode/decode()? Please add a comment, this seems totally useless? You just want an array, why can't you cast the result object to an array?
5. I think we can assume that project titles do not contain malicious text most of the time, but I would still sanitize them before printing to not open up any obscure XSS attack vectors. Yes, I think those titles are user provided text. See https://drupal.org/node/28984

But that are not critical application blockers, so ...

Thanks for your contribution, Jay.Chen!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.