[D7] Commerce pay with a tweet

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Updated issue summary.

Hello flebrenn,

I reviewed your module. At first glance, the source looked OK. I proceedeed to installing the module, everything was OK also.

However, as I was using Commerce Kickstart, I realized that the path to the module configuration may be confusing since there is no "Home > Administration > Store > Configuration > Commerce pay with a tweet" in Commerce Kickstart Admin theme. Also, it might be a good idea to be able to access to this configuration directly from the module list, since I believe this is the fallback location where people would look when they don't find it anywhere else.

When viewing the online help, I got the following warnings:

Warning: Invalid argument supplied for foreach() in element_children() (line 6545 of /XXX/includes/common.inc).
Warning: Illegal string offset '#children' in drupal_render() (line 6012 of /XXX/includes/common.inc).
Warning: Illegal string offset '#children' in drupal_render() (line 6022 of /XXX/includes/common.inc).
Warning: Illegal string offset '#children' in drupal_render() (line 6060 of /XXX/includes/common.inc).
Warning: Illegal string offset '#printed' in drupal_render() (line 6067 of /XXX/includes/common.inc).

I'm not sure if they are related to Commerce Kickstart but it should be good to take them into consideration given the popularity of this package for Drupal Commerce websites.

Finally, the online help might be improved by providing HTML contents with reference links instead of loading the raw README file.

Review of the 7.x-1.x branch:

• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: /home/klausi/pareview_temp/commerce_pay_with_a_tweet.module
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 4 WARNING(S) AFFECTING 4 LINE(S)
  --------------------------------------------------------------------------------
   404 | WARNING | Unused variable $delta.
   424 | WARNING | Unused variable $entity_id.
   457 | WARNING | Redeclaration of function parameter $user as global variable.
   489 | WARNING | Unused variable $delta.
  --------------------------------------------------------------------------------
  
  
  FILE: /home/klausi/pareview_temp/commerce_pay_with_a_tweet.page.inc
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 2 WARNING(S) AFFECTING 2 LINE(S)
  --------------------------------------------------------------------------------
   135 | WARNING | Unused variable $tweet.
   155 | WARNING | Unused variable $mime.
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. commerce_pay_with_a_tweet_menu_alter(): why is the kickstart hard coding necessary here? Please add a comment why this is needed.
2. _commerce_pay_with_a_tweet_get_options_list(): Do not use db_select() for simple static queries, use db_query() instead. See http://drupal.org/node/310075
3. commerce_pay_with_a_tweet_rules_condition_info(): this should be moved to a *rules.inc file, along with all other Rules specific hooks.
4. commerce-pay-with-a-tweet-payment.tpl.php: all user facing text must run through t() for translation.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to kscheirer as he might have time to take a final look at this.

Why is the menu title "Twitter callback 2" ?

I'm not sure why the file download code is in this module, shouldn't that be a checkout rule instead? Theoretically you could allow users to pay for anything with a tweet - it's just a payment gateway right? Also the twitter connect code, isn't that in the Pay with a Tweet module already?

None of those are blocking issues though.

Thanks for your contribution, flebrenn!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2076795

Project 2: https://drupal.org/node/2059401

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Let's leave this as fixed. You shouldn't need to apply again flebrenn, you can promote your own sandboxes to full projects now.

Updated issue summary.