[D7] Elimai Theme

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2072859

Project 2: https://drupal.org/node/2028851

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxrameshrasaiyan2023803git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi rameshrasaiyan,

Manual review:

Installed theme on clean D7, theme setup was quick except one small thing,
in theme settings when i enter Social Block Title, nothings happen, where should I see this block title?

Boostrap library (css, js) is 3rd party code, and is not generally allowed on Drupal.org.
You should use Libraries API for bootstrap ( recommended method for adding 3rd party code without directly including the code on Drupal.org). More about 3rd party code & Drupal: https://drupal.org/node/422996

Hi,

Manual review:

Social block title - OK
Theme works default with CDN, also tested with libraries, also works. (no errors)
You can mention only in readme file (same as is on project page) part about installation

Noticed that you attaching some css through javascript on theme, i am not sure what is more Drupal way,
but you can also change output of menu through overriding. ( https://drupal.org/node/341628)

Except that last (not sure), look like project is ready, but someone from Review team should confirm / or not.

Regards

hi,

- I think better to use path_to_theme() -> drupal_get_path()
- use libraries_load();
- use l() for links.
- check this

// Ensure that __DIR__ constant is defined:

In _elimai_load_bootstrap() case 'libraries', you should use the Libraries API if it's installed to determine the library path, it's not always set to sites/all/libraries.

Seems like a nice theme!

----
Top Shelf Modules - Crafted, Curated, Contributed.

manual review:

1. elimai_form_system_theme_settings_alter(): doc block is wrong, see https://drupal.org/node/1354#hookimpl
2. elimai_preprocess_page(): this is vulnerable to XSS exploits. If I enter t"><script>alert('XSS');</script><a href="u as twitter URL I get a nasty javascript popup. You need to sanitize user provided text before printing. Make sure to read https://drupal.org/node/28984 again. And please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Added the Reviews of other projects.

Hi, the search button height is smaller then search input box in firefox. maybe you can add height property into css file:

.form-search .input-append .btn {
    height:30px;
}

manual review:

1. "'#default_value' => check_plain(theme_get_setting('breadcrumb_delimiter')),": the #default_value property is sanitized automatically by the form API and double escaping is bad. Make sure to read https://drupal.org/node/28984 again.
2. elimai_preprocess_page(): actually you should use check_url() here, see also http://drupalscout.com/knowledge-base/drupal-text-filtering-cheat-sheet-... . So I can still mess around with something like "javascript:alert(0)". Not sure how to build a more useful exploit though.

Although you should definitely fix those issues they are not blockers and since this was rtbc otherwise already ...

Thanks for your contribution, rameshrasaiyan!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.