-- SUMMARY --

The jqueryui formatters module provides a suite of new display formatters to apply to your fields.
Three new formatters are provided (Dialog, Accordion and Tabs) to 'text', 'text_long' and 'text_with_summary' field types.
Although Accordion and tabs are available for single value fields, They usually become more interesting for multiple value fields.

https://drupal.org/sandbox/Enxebre/2097961

-- REQUIREMENTS --

Drupal 7.x

-- INSTALLATION --

* Install as usual.
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Enxebre/2097961.git jqueryui_formatters

-- CONFIGURATION --

* Configure the way you want to show your fields in
admin/structure/types/manage/your-content-type/display
if there is any field of type 'text', 'text_long' and 'text_with_summary' you will be able to choose three new options in the formatter section (Dialog, Accordion or Tabs)

* When you choose one of the new formatters you will be able to manage some
settings for display custmization

-- CONTACT --

Current maintainers:
* Alberto García Lamela (Enxebre) - drupal.org/user/1205082

-- NOTE --

Similar modules and main points:

Field formater conditions - https://drupal.org/project/ffc
Custom formatters - https://drupal.org/project/custom_formatters

Reviews of other projects:
https://drupal.org/node/2085833#comment-7902871
https://drupal.org/node/2097475#comment-7901629
https://drupal.org/node/2086333#comment-7909271
https://drupal.org/node/2096821#comment-7909701
https://drupal.org/node/1971496#comment-7909805
https://drupal.org/node/2061357#comment-7918455
https://drupal.org/node/2086333#comment-7922027
https://drupal.org/node/2098719#comment-7930209
More reviews:
https://drupal.org/node/2104683#comment-7939887
https://drupal.org/node/2075353#comment-7939971
https://drupal.org/node/2087221#comment-7940107
https://drupal.org/node/2084467#comment-7940265
https://drupal.org/node/2106629#comment-7946319

Files: 

Comments

Issue summary:View changes

indenting text

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Issue summary:View changes

cleaning text

Issue summary:View changes

install link

Issue summary:View changes

download url

Issue summary:View changes

adding reviews

Issue summary:View changes

adding reviews

review bonus

Status:Needs review» Needs work

Hi Enxebre,

I manually reviewed your module code and found the following minor things.

You have used anchor tag and ordered list tag in the inc file, you should use the drupal API l() and theme('item_list', array(), array()) function.

Thanks,
Ramesh

Status:Needs work» Needs review

Hi,
I agree with you there is no reason for do not make use of Drupal API in this case. Changed.
Thank you!!

Regards.

Issue summary:View changes

more reviews

The Coder module indicates that on Line 319 of jqueryui_formatters.field.inc:

String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms [style_string_spacing]
  $output = $link . '<div class="jqueryui-formatters-text" title="' .  $title . '" style="display:none;" id="jqueryui-formatters-text-' . $unic_item_id . '">' . $text . '</div>';

When I install the module and run it, I get the following error:

Fatal error: Call to undefined function entity_id() in /Users/drupal/Sites/drupal/reviews/reviews_01/sites/all/modules/jqueryui_formatters/jqueryui_formatters.field.inc on line 156

Any suggestions for how to try and resolve that?

Hi,
sorry!! I forgot to add the entity API dependency to the .info file. Fixed.

Thank you willyk.

Regards.

Issue summary:View changes

more reviews

StatusFileSize
new29.07 KB

That resolved that issue. I was able to test it and it works ok; although unfortunately when you select the "Tabs" option in manage display is also uses jquery UI on the edit tabs for the node (see attached screenshot. I'm guessing that's unintended and suggest trying to narrow down your code that it's not rendering on these tabs. This looks like a pretty handy module, looking forward to seeing it come to life!

Hi,
thank you very much for the inspection willyk!

I´ve narrowed down js behaviour to the ".jqueryui-formatters" class.

Regards!!

Issue summary:View changes

adding review

Assigned:Unassigned» stBorchert
Status:Needs review» Reviewed & tested by the community
Issue tags:-PAReview: review bonus

Thanks you for your reviews. When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no major flaws).

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    FILE: /home/klausi/pareview_temp/tests/jqueryui_formatters.test
    --------------------------------------------------------------------------------
    FOUND 5 ERROR(S) AND 1 WARNING(S) AFFECTING 5 LINE(S)
    --------------------------------------------------------------------------------
    15 | ERROR   | Missing function doc comment
    19 | WARNING | A comma should follow the last multiline array item. Found:
        |         | 'Field UI'
    23 | ERROR   | Missing function doc comment
    23 | ERROR   | Visibility must be declared on method "setUp"
    25 | ERROR   | If the line declaring an array spans longer than 80 characters,
        |         | each element should be broken into its own line
    36 | ERROR   | Visibility must be declared on method
        |         | "testWarningsSettingsJqueryuiFormatters"
    --------------------------------------------------------------------------------

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to stBorchert as he might be able to take a final look at this.

Trying to remove tag again.

Hi,
master branch removed.
#attached property is now used instead of drupal_add_* functions.

Thank you very much for your time.

Regards!

Issue summary:View changes

adding review

Issue summary:View changes

adding more reviews

Issue summary:View changes

More reviews

Issue summary:View changes

More reviews

Issue summary:View changes

fixing lowercase letter

Adding Review bonus

Issue summary:View changes

Adding more reviews

Status:Reviewed & tested by the community» Fixed

no objections for more than a week, so ...

Thanks for your contribution, Enxebre!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Thank you everybody for your time!

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

Adding review