Comments

zipme_hkt’s picture

Status: Needs review » Needs work

HI takim,
There are some issue report by http://pareview.sh, issue report here: http://pareview.sh/pareview/httpgitdrupalorgsandboxtakim2019483git

Please fix it.

takim’s picture

Issue summary: View changes

change description

Vik’s picture

file: table_booking.module
--------------------------------------------------------------------------------
FOUND 26 ERROR(S) AFFECTING 22 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | You must use "/**" style comments for a file comment
7 | ERROR | Missing function doc comment
18 | ERROR | Line indented incorrectly; expected 2 spaces, found 0
18 | ERROR | Inline comments must start with a capital letter
54 | ERROR | Missing function doc comment
63 | ERROR | Missing function doc comment
69 | ERROR | Case breaking statements must be followed by a single blank line
71 | ERROR | The first index in a multi-value array must be on a new line
71 | ERROR | The first index in a multi-value array must be on a new line
73 | ERROR | Case breaking statements must be followed by a single blank line
75 | ERROR | The first index in a multi-value array must be on a new line
75 | ERROR | The first index in a multi-value array must be on a new line
77 | ERROR | Case breaking statements must be followed by a single blank line
79 | ERROR | Inline control structures are not allowed
79 | ERROR | Line indented incorrectly; expected 6 spaces, found 19
83 | ERROR | Blank lines are not allowed after DEFAULT statements
91 | ERROR | Missing function doc comment
102 | ERROR | Missing function doc comment
109 | ERROR | Missing function doc comment
111 | ERROR | Line indented incorrectly; expected 2 spaces, found 0
113 | ERROR | Blank lines are not allowed after CASE statements
114 | ERROR | Whitespace found at end of line
115 | ERROR | No space found after comma in function call
116 | ERROR | The first index in a multi-value array must be on a new line
117 | ERROR | Concat operator must be surrounded by spaces
121 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

Vik’s picture

function t($string, array $args = array(), array $options = array())

$string: A string containing the English string to translate.

line 71..72
$options = array('11:00' => t('11:00'), '12:00' => t('12:00'),
'13:00' => t('13:00'), '14:00' => t('15:00'));

takim’s picture

Status: Needs work » Needs review

Hi translation function is removed from numeric string.

PA robot’s picture

Status: Needs review » Closed (duplicate)
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/1454042

Project 2: https://drupal.org/node/2084877

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

Issue summary: View changes

change git repo path

avpaderno’s picture

Issue summary: View changes
Related issues: +#1454042: [D7] User Schedule