Update file_entity and media to version 2.0-alpha3

Aha, yes, this is super important! I didn't see that they had the -alpha release. I'm looking forward to seeing what you find. :-)

I did it (using File entity (fieldable files) 7.x-2.0-alpha2) and now when using Panelizer and adding file field content as a pane i get a couple of warnings in the modal window:

Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /srv/bindings/1559a90be77b4b9591fb0789dc5890b1/code/includes/entity.inc).
Warning: array_merge(): Argument #2 is not an array in panopoly_magic_form_alter() (line 282 of /srv/bindings/1559a90be77b4b9591fb0789dc5890b1/code/profiles/panopoly/modules/panopoly/panopoly_magic/panopoly_magic.module)

Line 282 being the use of file_load() $form_state['entity']->{$field_name}[LANGUAGE_NONE][0] = array_merge((array) file_load($form_state['entity']->{$field_name}[LANGUAGE_NONE][0]['fid']), $form_state['entity']->{$field_name}[LANGUAGE_NONE][0]);

It's not actually possible to complete the 'Formatter Styles' step due to the ajax request coming back with PHP errors.

The version of File Entity used in rc5 suffers from this bug: #1959260: Ensure a 'file_access' tag is used on all queries of outputted files => alpha1 breaks EntityFieldQuery not releated to files. If you turn on the Managed Files plugin in your Linkit profile, Linkit breaks. No matter what you type in the box, you get no results.

We are also testing rc5 with updated Media and File Entity and will report back.

Updating title and adding "sprint" tag because this is something we want to fit in if possible.

Attached is an initial patch to update Media, File Entity and Media YouTube (it turns out that 2.0-rc3 depends on an API function that was removed from Media in the meantime). So, this could supercede this issue: #2125255: Update media_youtube to version 2.0-rc4

Also, it's worth noting that Open Atrium performed this update in there -dev branch and will be releasing with it soon. Watching their issue queue, there's apparently some permission changes necessary? #1990746: Split file permissions per file type, just like File_entity does

Lots more testing of this will be necessary!

I've found a bug, which is basically the same bug from #2125255: Update media_youtube to version 2.0-rc4: After the update, you can't insert the YouTube video player in WYSIWYG - only the "Link" or "Thumbnail".

However, creating a "File" field which takes YouTube URLs and setting the "Display format" to "Rendered file" with a view mode of "Default" will correctly display the YouTube player.

I was hoping this would get fixed by the Media upgrade! Unfortunately, no. :-/

I'm not sure which module is responsible for this bug - it could be one of the media modules or maybe something new needs to be configured by Panopoly.

Digging deeper on the bug described in #7: If I manually add the special media markup (ie. [{"fid":"55","view_mode":"default","fields":{"format":"default"},"type":"media","attributes":{"class":"file media-element"}}]]) to the node, it will actually display the player correctly!

So, it's the Wysiwyg editor NOT inserting the code for some reason. Also after inserting it manually, when I edit the node again, the Wysiwyg editor will remove it. Still trying to track down what's at fault...

Gah! Ok, I finally solved this issue after finding this in the "Media YouTube" queue: #1889120: No media tag inserted in WYSIWYG editor for youtube video.

Apparently, we need to enable the "YouTube Preview Image" display on both the "Default" and "Teaser" displays of "Video" in order for YouTube to work with Wysiwyg. We'll need to get this built into Panopoly somewhere, but I'm not sure where yet...

It looks like the panopoly_widgets_file_default_displays_alter() is supposed to be handling enabling this, but it isn't working. :-/ I just tried a fresh install. We might need an update function to force it to refresh or something? Still investigating.

Here is a patch that attempts to address the YouTube/WYSIWYG issues but it needs a ton more testing!

Gah! Some other changes from another patch snuck in. :-) Here is a clean patch.

I tested a fresh install with my patch and everything worked great! I still need to do more upgrade testing.

I just tested an upgrade from Panopoly 1.0-rc5 and everything went perfectly, as far as I can tell. :-)

I'm going to attempt to verify the issues reported in comments #3 and #4 before committing this.

However, Open Atrium 2.12 upgraded to new Media and they aren't experiencing any problems, so I'm feeling much more confident about this. :-)

For #3: I created a new content type with a File field that has the Media selector. I enabled Panelizr and was able to add the field to the full page override without any problems! I got through the "Formatter styles" screen, just fine.

For #4: I enabled the "Managed files" plugin in the LinkIt profile, and Linkit still worked as expected!

I think I'm going to commit this in a little bit to try and get wider testing - we can always revert the before release if problems are found.

@dsnopek - You should follow #2067063: Wysiwyg integration is broken. I believe there a few major outstanding issues with Media and inline media placed using the wysiwyg editors.

Here are the issues I have my eye on:

1. Add a white list of file fields that can be overwritten when the file is added in the wysiwyg #2062721: Add a white list of file fields that can be overwritten when the file is added in the wysiwyg
2. Wysiwyg -- Alt and Title fields require some special handling - #2126697: Wysiwyg -- Alt and Title fields require some special handling.. Patch in https://drupal.org/comment/8162931#comment-8162931 is believed to work
3. Wysiwyg -- Ensure height and width are always set in style attribute to avoid being overwritten during rendering. #2126691: Wysiwyg -- Ensure height and width are always set in style attribute to avoid being overwritten during rendering.
4. WYSIWYG-inserted images lose ckeditor styles #2148641: WYSIWYG-inserted images lose ckeditor styles
5. Can't edit link text for uploaded files (not images) #2139461: Can't edit link text for uploaded files (not images)
6. Ajax callbacks in the media overlay cause the active tab to switch tab unexpectedly #1802026: Ajax callbacks in the media overlay cause the active tab to switch tab unexpectedly Note: Just checked on 12/4/2013 and it is still a problem
7. Multiple WYSIWYG editors on one form breaks Media integration #2102623: Multiple WYSIWYG editors on one form breaks Media integration
8. Multiple items inside Media tagmap variables makes it broken. #2116639: Multiple items inside Media tagmap variables makes it broken.
9. media filter adds extra space at beginning and end of input #1828558: media filter adds extra space at beginning and end of input
10. Preview doesn't respect restricted view modes #2149315: Preview doesn't respect restricted view modes
11. WYSIWYG-inserted images lose ckeditor styles #2148641: WYSIWYG-inserted images lose ckeditor styles and ckeditor styles break media module markup #2028255: ckeditor styles break media module markup
12. Media browser view library exposed form submit problem #1319528: Media browser view library exposed form submit problem
13. Ajax callbacks in the media overlay cause the active tab to switch tab unexpectedly #1802026: Ajax callbacks in the media overlay cause the active tab to switch tab unexpectedly

Hope that helps

@gmclelland: Thanks for the list of issues! It will be very helpful. :-)

However, are any of these issues relavent to this issue? Ie. are they bugs that don't exist in the old dev version of Media used in Panopoly 1.0-rc5, but ARE present in Media 2.0-alpha3?

If not, then this list probably belongs in a new issue concerning bugs with Media and WYSIWYG. So long as upgrading to Media 2.0-alpha3 doesn't make the situation any worse, then I'd still like to go ahead with it as soon as possible.

@gmclelland: I looked through those issues and a lot of them appear to be CKEditor-related, so they should probably be linked on #1965864: Support CKEditor in Panopoly instead. Could you post them there? Currently, Panopoly doesn't support CKEditor in it's WYSIWYG implementation.

Also, it doesn't appear that any would prevent us from upgrading Media to 2.0-alpha3 - I didn't see any issues that looked like regressions. However, if you're aware of any, please let me know!

Looking at Open Atrium, it appears they went 12 revisions passed Media 2.0-alpha3 to revision 4a88319. I've e-mailed Mike Potter for more background on that decision to see if it makes sense for Panopoly as well. I'm going to hold off on committing this until he gets back to me.

I can't tell just by looking at the make file in panopoly widgets what the date that commit was from:

projects[media][version] = 2.x-dev
   projects[media][subdir] = contrib
   projects[media][download][type] = git
   projects[media][download][revision] = 2319170
   projects[media][download][branch] = 7.x-2.x

You might want to make sure to check the child issues of #2067063: Wysiwyg integration is broken.

I haven't used Panopoly in a while so I'm not sure of how many of those issues are relevant. I just wanted to give you a heads up - just in case.

You might want to use the latest dev of Media and File Entity. It contains the fix for #2067063: Wysiwyg integration is broken and it also includes two new sub modules.

Also this commit http://drupalcode.org/project/media.git/commit/5faa4bb44583688edd1a77a62...
adds a huge usability improvement with the media browser by making it much bigger.

In case you don't know, there is also https://drupal.org/project/media_dev that makes for easy testing of patches with http://simplytest.me

It always includes the latest dev versions of the media and file_entity modules.

Hope that helps

Thanks!

The version in Panopoly 1.0-rc5 is from 7/23. Right now, my goal is just getting us up to a recent version that doesn't have any MORE bugs than the version in currently in Panopoly 1.0-rc5. :-) I'd rather wait until after the Panopoly 1.0 release (our goal is for that to happen next week!) before attempting to get any improvements in.

So, I'm going to go for either Media 2.0-alpha3 or the revision that Open Atrium went to if there is a compelling bug fix.

Just fyi... I believe the problem commit was Thu, 15 Aug 2013 http://drupalcode.org/project/media.git/commit/3cb8d2c768721ff31cfad962e...
that changed the wysiwyg embedding.

Ok, thanks! I've tested WYSIWYG quite a lot with the new Media and the only regression I personally found was with YouTube in WYSIWYG, which is fixed in my patch. However, verything else appears to work fine.

Mike Potter responded to me saying that they did go up to 4a88319 to fix some bugs, but he doesn't remember exactly what they were. However, look at the differences between 2.0-alpha3 and 4a88319, nothing affect the database so it should be safe to go there - we can always revert back down to 2.0-alpha3 with no ill effects. It also includes the change that makes the popup bigger. :-) Everything seems to work in my testing.

So, I'm going to go with 4a88319 for now. We can explore trying even newer -dev versions after 1.0 is released next week. New patch is attached - commit is forth-comming!

Committed in 6dd95f2.

@mpotter: Heh, awesome, I'm glad it worked for you guys! If you update to the latest Git revision of panpoly_widgets, you'll get the fix without necessarily having to add anything in oa_media unless you're customizing it further.