Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Testing Drupal\Tests\cdn\Functional\CdnIntegrationTest
E.....F 7 / 7 (100%)
Time: 00:33.242, Memory: 4.00 MB
There was 1 error:
1) Drupal\Tests\cdn\Functional\CdnIntegrationTest::testCss
Behat\Mink\Exception\ExpectationException: The string "url(" was not found anywhere in the HTML response of the current page.
/var/www/html/vendor/behat/mink/src/WebAssert.php:794
/var/www/html/vendor/behat/mink/src/WebAssert.php:324
/var/www/html/core/tests/Drupal/Tests/WebAssert.php:496
/var/www/html/modules/contrib/cdn/tests/src/Functional/CdnIntegrationTest.php:141
/var/www/html/modules/contrib/cdn/tests/src/Functional/CdnIntegrationTest.php:111
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
--
There was 1 failure:
1) Drupal\Tests\cdn\Functional\CdnIntegrationTest::testFarfuture with data set "js" ('core/modules/system/js/system...les.js', ':relative:', 'core/modules/system/js/system...les.js', 'application/javascript')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'application/javascript'
+'text/javascript; charset=UTF-8'
/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122
/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/IsIdentical.php:79
/var/www/html/modules/contrib/cdn/tests/src/Functional/CdnIntegrationTest.php:212
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
The latter is caused by #84883: Unicode::mimeHeaderEncode() doesn't correctly follow RFC 2047 — see https://www.drupal.org/node/3312139
The former is I think caused by #1014086: Stampedes and cold cache performance issues with css/js aggregation — see https://www.drupal.org/node/2888767]
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#14 | 3347181-14.patch | 6.21 KB | Wim Leers |
#14 | interdiff.txt | 1.08 KB | Wim Leers |
#13 | 3347181-13.patch | 6.2 KB | Wim Leers |
#13 | interdiff.txt | 3.6 KB | Wim Leers |
#11 | 3347181-11.patch | 5.41 KB | Wim Leers |
Issue fork cdn-3347181
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
Wim LeersComment #4
Wim LeersHm …
is in the CSS aggregate with the CDN module installed but turned off… looks like there is potentially a bug in core here. It must be either that or a weird new edge case when the CDN module is installed. 🤔
(Note the
subdirectory/subdirectory
— should be there only once.)Comment #5
Wim LeersThat seems to confirm it. Core issue for this: #3353808: Add additional test coverage for CssOptimizer.
Comment #6
Wim LeersOkay, looks like I did find a genuine core regression/BC break this time around… looks like CSS/JS aggregates now incorrectly get absolute URLs: #3354204: [regression] Since #1014086 generated CSS assets have absolute URLs without varying by url.site cache context.
Comment #7
Wim LeersComment #8
Wim LeersThis is hard-blocked on the #3354204: [regression] Since #1014086 generated CSS assets have absolute URLs without varying by url.site cache context core issue.
Comment #9
Wim LeersComment #10
Wim LeersThat landed!
Comment #11
Wim LeersNow that it's green locally, let's make it pass on both
10.0
and10.1
…Comment #13
Wim LeersComment #14
Wim LeersComment #15
Wim LeersComment #17
Wim Leers