Problem/Motivation

Testing Drupal\Tests\cdn\Functional\CdnIntegrationTest
E.....F                                                             7 / 7 (100%)

Time: 00:33.242, Memory: 4.00 MB

There was 1 error:

1) Drupal\Tests\cdn\Functional\CdnIntegrationTest::testCss
Behat\Mink\Exception\ExpectationException: The string "url(" was not found anywhere in the HTML response of the current page.

/var/www/html/vendor/behat/mink/src/WebAssert.php:794
/var/www/html/vendor/behat/mink/src/WebAssert.php:324
/var/www/html/core/tests/Drupal/Tests/WebAssert.php:496
/var/www/html/modules/contrib/cdn/tests/src/Functional/CdnIntegrationTest.php:141
/var/www/html/modules/contrib/cdn/tests/src/Functional/CdnIntegrationTest.php:111
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

--

There was 1 failure:

1) Drupal\Tests\cdn\Functional\CdnIntegrationTest::testFarfuture with data set "js" ('core/modules/system/js/system...les.js', ':relative:', 'core/modules/system/js/system...les.js', 'application/javascript')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'application/javascript'
+'text/javascript; charset=UTF-8'

/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122
/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/IsIdentical.php:79
/var/www/html/modules/contrib/cdn/tests/src/Functional/CdnIntegrationTest.php:212
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

The latter is caused by #84883: Unicode::mimeHeaderEncode() doesn't correctly follow RFC 2047 — see https://www.drupal.org/node/3312139

The former is I think caused by #1014086: Stampedes and cold cache performance issues with css/js aggregation — see https://www.drupal.org/node/2888767]

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork cdn-3347181

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Title: Tests are failing against Drupal 10.1.x due to upstream changes » 10.1.x compatibility: tests are failing against Drupal 10.1.x due to upstream changes

Wim Leers’s picture

Hm …

url(/subdirectory/subdirectory/core/misc/icons/787878/move.svg)

is in the CSS aggregate with the CDN module installed but turned off… looks like there is potentially a bug in core here. It must be either that or a weird new edge case when the CDN module is installed. 🤔

(Note the subdirectory/subdirectory — should be there only once.)

Wim Leers’s picture

Wim Leers’s picture

Okay, looks like I did find a genuine core regression/BC break this time around… looks like CSS/JS aggregates now incorrectly get absolute URLs: #3354204: [regression] Since #1014086 generated CSS assets have absolute URLs without varying by url.site cache context.

Wim Leers’s picture

Wim Leers’s picture

Wim Leers’s picture

Status: Active » Postponed
Wim Leers’s picture

Status: Postponed » Needs review

That landed!

Wim Leers’s picture

FileSize
5.41 KB

Now that it's green locally, let's make it pass on both 10.0 and 10.1

Status: Needs review » Needs work

The last submitted patch, 11: 3347181-11.patch, failed testing. View results

Wim Leers’s picture

Status: Needs work » Needs review
FileSize
3.6 KB
6.2 KB
Wim Leers’s picture

FileSize
1.08 KB
6.21 KB
Wim Leers’s picture

Status: Needs review » Reviewed & tested by the community

  • Wim Leers committed f6f3d0b5 on 4.x
    Issue #3347181 by Wim Leers: 10.1.x compatibility: tests are failing...
Wim Leers’s picture

Assigned: Wim Leers » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.