Fixing html breakage once and for all

Subscribe

#2 works!! You saved me :)

Thanks, Kenneth. I really appreciate you stepping in and giving this module some love. Some feedback about the smaller patch in #9:

Firstly, check out http://drupal.org/project/dreditor. If you install that, you get "Review" buttons (well, links that look like buttons) appearing next to patches on d.o. issue comments, that when you click, opens a neat patch review tool. One of the things it does is highlight in red any whitespace that doesn't conform to Drupal coding standards (e.g., tabs instead of spaces and trailing whitespace). You have several of those in the patch. Please fix them.

+++ b/devel_themer.css
@@ -1,3 +1,9 @@
+span.k.e.n.t.h.v[thmr] {
+	display:inline;
+	padding:0;
+	margin:0;
+}
+
...
+++ b/devel_themer.module
@@ -184,6 +184,118 @@ function devel_themer_module_implements_alter(&$implementations, $hook) {
+          $this->tree[$cur][0] = "<span thmr='$key' class='k e n t h v'>{$current[0]}</span>";

I think this is overkill, and maybe best left to follow-up issues as specific use-cases come up. I wonder if we could just start with a single class ("devel-themer-wrapper" ?), which would already be better than what the module has currently, and then see where that's insufficient.

+++ b/devel_themer.module
@@ -184,6 +184,118 @@ function devel_themer_module_implements_alter(&$implementations, $hook) {
+class devel_themer_html {

I didn't review the implementation in detail yet. Is there no existing GPL implementation of this functionality that we can use rather than something custom? Maybe there isn't, but if there is, I think it would be good to leverage something that's already been thoroughly tested and is being maintained.

It is possible that two different thmr attributes are added to the same tag.

Can you give some examples of when this happens (any examples from core only, or only with certain contrib modules/themes)? I'd like to make sure people can test these situations in different browsers, and share their results.

I'd also like to see more feedback here from others (@afeijo: thanks for yours, but can you state what browser(s) you tried this on), so I asked for that in #425716-15: Use comments instead of spans to markup theme calls.

just fyi, I got this error:
# patch < html_fix_revised_0.patch
patching file devel_themer.css
patching file devel_themer.js
patching file devel_themer.module
Hunk #2 FAILED at 318.
Hunk #3 succeeded at 372 (offset -10 lines).
1 out of 3 hunks FAILED -- saving rejects to file devel_themer.module.rej

#16 worked for me, thanks

#15 Worked for me on the context module page.

It works great. Way better than it was.

#15 is not working with the current version:

patching file devel_themer.css
patching file devel_themer.module
Hunk #2 FAILED at 317.
Hunk #3 succeeded at 393 (offset 11 lines).
1 out of 3 hunks FAILED -- saving rejects to file devel_themer.module.rej

I'm trying this patch to get vertical tabs working according to this issue.
Could you look into it?

awesome!
devel_themer 7.x-1.x-dev does not work out of the box (with my zen child theme) but using this patch (#15) it does so I think this should get into dev as soon as possible.
thanks!

I've tried all the patches in succession and when the pop-up dialog opens it still pushes everything off of the shortcut bar (hidden or not). The buttons themselves still work but with my theme's background color you can't even see them to find them unless you happen to hover over them.

RTBC for me. Module works exactly as expected, with the patch from #22, in several different themes, including core, contrib and custom ones.

"Minor" would be the appropriate status for an issue describing the effects *after* n4rc1ssus applied the patch (see #23), but, the impact without the patch at all is still major. That's the appropriate status for the current issue.

I've tested #22 and it makes the module usable again. Thank you.

Is there a final patch that does all of the above?

I've applied some now (started with the last one) but things still aren't working for me. The toggle div doesn't even appear in the code (themer-toggle).

It does work if the Views Slideshow is disabled though.

Patch #22 should be all you need.

That's the very first one I had applied, to no avail (from which I started applying the earlier ones).

I disabled the slideshow for a while and got what I needed.

I'm not involved with the development, maintenance or support of this module, but, it almost certainly would be of help to those who are if you were to describe what "doesn't work" looks like.

Does nothing at all?

Yields broken website?

Generates error messages?

Isn't installable?

Something else?

Under what conditions: With core themes, contrib themes or your custom theme?

For what it's worth, I also use Views Slideshow, and didn't have a problem.

The only thing that's happening, or not happening, is the checkbox appearing on the left bottom. It's there in the admin theme (Seven), but not in the custom theme (Omega theme).

Other modules being actively used on those pages: Language switcher dropdown, Featured content.

#22 needs to be re-rolled. Its no longer applies cleanly to 7-x-1.x-dev.

Needs work, according to #32.

Getting the following after trying to pull down drush dl devel_themer:

File devel_themer-7.x-1.x-dev.tar.gz is corrupt (wrong md5 checksum).

However, pulled down nicely via git clone, but after enabling I get a http error 500.

Works like a charm! Don't know what went wrong the first time around.

Using latest (dev) version but i am still not seeing a theme info checkbox.

tested on:
bartik
garland
corporate clean

finally got this to work with 7.x-1.12 simplehtmldom instead of 7.x-2.0/7.x-2.x-dev