Problem/Motivation
Prompted by this conversion:
http://drupal.org/node/1896060#comment-7274838
This is in an attempt to allow those output tags in
format_rss_channel()
format_rss_item()
to be rendered as twig files. The issue above is for aggregator module but this would be a template needed by both node_feed()
, which is used by taxonomy
and the aggregator module.
Proposed resolution
Create a new theme function for these format functions, and use the theme for theme_aggregator_page_rss()
and node_feed()
API changes
Removes these functions and replaces them with Twig templates:
format_rss_channel()
format_rss_item()
Related Issues
#401584: Convert format_rss_items(), format_rss_channel() and format_xml_elements() to use SimpleXML
#1896060: aggregator.module - Convert PHPTemplate templates to Twig
Comments
Comment #1
joelpittettagging.
Comment #2
shanethehat CreditAttribution: shanethehat commentedI'd like to have a go at this, but if I'm taking too long anyone feel free to step in.
Comment #3
joelpittet@shanethehat great, thank you! It's not very similar to the other conversions because we haven't really touched format_ functions. Though if the *new* theme template can handle it it may also allow consolidation of Views RSS as well #1843758: Convert views/templates/views-view-row-rss.tpl.php to twig
Comment #4
star-szrAt this time this issue could almost be postponed IMO, it's more of a long-term thing.
@shanethehat - Please join us in #drupal-twig if you'd like to help out with the Twig conversion effort in general. Thanks! :)
Comment #5
joelpittetI agree, postponing. The wash may iron this.
Comment #6
mgifford#1843758: Convert views/templates/views-view-row-rss.tpl.php to twig got into Core. Has this indeed ironed itself out?
Would have been way better to have been able to just ask this in person in SF. :)
Comment #7
mikeker CreditAttribution: mikeker commentedComment #8
mgiffordComment #9
star-szrI think we're good because of #2251111: Remove format_rss_item() and format_rss_channel(), thanks for the bump @mgifford :)