Problem/Motivation

The return type on the setChangedTime and setCreatedTime methods on EckEntityInterface is EckEntityInterface, but that's not specific enough if the entity uses bundle classes with extra methods/interfaces.

Proposed resolution

Change the return type hint to static.

Issue fork eck-3363498

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DieterHolvoet created an issue. See original summary.

DieterHolvoet opened merge request !33

DieterHolvoet’s picture

DieterHolvoet CreditAttribution: DieterHolvoet at Minsky commented
Status: Active » Needs review
DieterHolvoet’s picture

DieterHolvoet CreditAttribution: DieterHolvoet at Minsky commented
Assigned: DieterHolvoet » Unassigned

  • Arrow committed 689b866f on 8.x-1.x authored by DieterHolvoet 
    Issue #3363498: Wrong return type hint on EckEntityInterface setters
Arrow’s picture

Arrow
Location Chicago
CreditAttribution: Arrow at Kalamuna commented
Status: Needs review » Fixed

Merged and backported to 8.x-1.x branch. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.