Do not translate field group labels using interface translation.

@Sutharsan sorry, where would a group's label be translated then, with this change?

Right, well, that's a separate issue to dealing with double-escaped HTML in group titles so I'm going to re-open and re-direct that issue.

I did a rebase against 8.x-3.x that seems to be in active development although it seems to me like a bug since is polluting the database with non-English strings since my site default language is not English.

After this change for translating the labels I think a schema change is needed:

In the field_group.field_group_formatter_plugin.base schema definition the type of the label is "string" and I think is should be "label" to make it translatable. Can someone confirm this?

So instead of

label:
      type: string
      label: 'Label of the fieldgroup'

it will read

label:
      type: label
      label: 'Label of the fieldgroup'

Lots of "label" there :)

And probably other translatable properties need to change from "string" to "label" or "text" if it is multiline according to
https://www.drupal.org/docs/8/api/configuration-api/configuration-schema...

Hi, i applied the last patch field_group-no-label-translation-2846617-6.patch, but i do not find where or how to translate the field group i have created

Field groups are inside Entity view displays and those are translatable. Altought there is no interface for it

#2546212: Entity view/form mode formatter/widget settings have no translation UI

But I think we have to change the schema so the labels are translatable.

Removing the t() is also a good idea for multilingual sites that have other default language than English. Gets very confusing.

@rodrigoaguilera yes, to my understanding too changing schema so that there is type: label and translatable: true should do it. And an update hook that will update the schema when module is already installed.

Creating the translation Yaml files is fairly simple for anyone who's not afraid of text files. :)

Well it wasn't that complicated, writing an update hook seems not to be necessary in this case. I attached a patch that changes the config schema to support reading translations if they are manually created in config/sync/[langcode]/core.entity_view_display.node.[bundle].[view_mode].yml.

Also attached is a version of the patch for 8.x-1.0, as I didn't want to move to beta version on the production site I need this for, someone else might want to use that too.

Re-roll of the patch against the latest dev branch commit (9ab1b99).

Testing out the new patch a hit a new issue: the output is double escaped:

* Once in code Html::escape()
* And automatically by twig when the variables are printed {{ label }} (see https://www.drupal.org/node/2296163)

I updated the patch and removed the need to Html::escape() in the formatters and alters.

This will also conflict with #2822299: Double-escaped HTML entities in group titles, which is already RTBC. The latest patch has also taken this issue in a new direction... but a good one. Personally, I'd suggest the latest patch here does the correct things, for both translation and HTML. Because of that, I'm going to close that other issue, even though it reached RTBC. People may not be happy with that, but that one was always aiming for a temporary workaround anyway, I believe (see comment #2822299-18).

Having said that, I haven't actually tested, I'm just reviewing the approach taken by the latest patch(es).

So, remaining steps here:
1) Address comment 13
2) Test & review

Patch #16 works for me.

Patch looks good.
It would be nice to find a way to build an UI for translating these items but it looks quite complicated.

Here is the updated patch for the 8.x-3.x branch

This patch conflicts with the one in #2878359: Field groups are not compatible with field layout so it's going to need a reroll soon

Rebasing this, we found this problem when working on #2546212: Entity view/form mode formatter/widget settings have no translation UI.

The patch in #21 looks good. Do we need an interdiff to #19 or simply review #21 now?
Is the patch from #2546212: Entity view/form mode formatter/widget settings have no translation UI required for this to work?

Cannot provide an interdiff since it is the same patch as #19 just rebased.

No need of the patch of the related issued. Just wanted to clarify how I ended up in this issue. :)

The patch should be ready for review.

#21 works great for me together with #2577761-73: We need a way to dynamically alter the list of config names for config mappers and #2546212-89: Entity view/form mode formatter/widget settings have no translation UI added to a Drupal 8.5.6 site.
The patch looks great, but I haven't checked if there are any strings left to change to labels.

Re-rolled and changed tabs description to label as well. Possibly it should be text?

Well that was bad, left a ) in 'Fieldset.php'....

Applied patch 21 but field group lables still not translateable!

Field group labels not translateable via UI.

Okay so field group isn't translatable at the moment generally? I'm asking, because I'm creating a multi language currently.
IMHO it's better to translate elements via string translation, when there's no other implemented solution available. Is there a way, where I can translate my field labels?

committed and pushed, thanks all!

Great news finally, thank you so much @swentel!!! :)

PS: No commit message here yet? Have you perhaps forgotten to mention this in the commit message? Or not yet pushed? - Just to ensure this was truely committed.

Ah crap, forgot to push, sorry :)

I'm using Field Group for the account form display (admin/config/people/accounts/form-display), but translation for the label doesn't seem to work. Can anyone confirm this?

Translation was still not working and I believe that it was missing t()
https://www.drupal.org/project/field_group/issues/3111107

It's config and should never got translated trough t(). That would trigger a lot of strange side effects on multi lang sites.