By default, Linkit will only serve public files with IMCE. Technically, IMCE is capable the serving of private files but doesn't provide support for access restrictions.

Linkit defaults to using the public files directory with IMCE but we see no benefit in doing this, especially when private files are a supported option under IMCE.

CommentFileSizeAuthor
#2 imce-private-2495911-2.patch500 bytesc8amlev

Comments

c8amlev’s picture

c8amlev commented

I'm working on this now.

c8amlev’s picture

c8amlev commented
StatusFileSize
new imce-private-2495911-2.patch500 bytes

Here's a patch that uses the file's url property rather than constructing one with the relative path. We don't think this should have any negative effects because the file's url should be correct anyway, even under the private file model.

ldpm’s picture

ldpm commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: imce-private-2495911-2.patch, failed testing.

Status: Needs work » Needs review

c8amlev queued 2: imce-private-2495911-2.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: imce-private-2495911-2.patch, failed testing.

c8amlev’s picture

c8amlev commented

I completed the simpletests locally without any fails. If anyone can provide insight on why there is a discrepancy in the results, I'd appreciate it. Thanks

GET admin/config/content/linkit/add returned 200 (44.22 KB). Browser linkit_profile.test 46 LinkitProfileUICRUDTestCase->testCreateProfile() Pass
Valid HTML found on "admin/config/content/linkit/add" Browser linkit_profile.test 46 LinkitProfileUICRUDTestCase->testCreateProfile() Pass
Verbose message Debug linkit_profile.test 46 LinkitProfileUICRUDTestCase->testCreateProfile() Debug
GET admin/config/content/linkit returned 200 (12.32 KB). Browser linkit_profile.test 46 LinkitProfileUICRUDTestCase->testCreateProfile() Pass
Valid HTML found on "admin/config/content/linkit" Browser linkit_profile.test 46 LinkitProfileUICRUDTestCase->testCreateProfile() Pass
Verbose message Debug linkit_profile.test 46 LinkitProfileUICRUDTestCase->testCreateProfile() Debug
The new profile was created. Other linkit_profile.test 48 LinkitProfileUICRUDTestCase->testCreateProfile() Pass
GET admin/config/content/linkit/list/test_profile/edit returned 200 (44.67 KB). Browser linkit_profile.test 51 LinkitProfileUICRUDTestCase->testCreateProfile() Pass
Valid HTML found on "admin/config/content/linkit/list/test_profile/edit" Browser linkit_profile.test 51 LinkitProfileUICRUDTestCase->testCreateProfile() Pass
Verbose message Debug linkit_profile.test 51 LinkitProfileUICRUDTestCase->testCreateProfile() Debug
HTTP response expected 200, actual 200 Browser linkit_profile.test 52 LinkitProfileUICRUDTestCase->testCreateProfile() Pass
Found field with name 'name' and value 'test_profile' Browser linkit_profile.test 56 LinkitProfileUICRUDTestCase->testCreateProfile() Pass
Found field with name 'admin_title' and value 'Test Profile' Browser linkit_profile.test 56 LinkitProfileUICRUDTestCase->testCreateProfile() Pass
Found field with name 'admin_description' and value 'This is a description for the Test Profile.' Browser linkit_profile.test 56 LinkitProfileUICRUDTestCase->testCreateProfile() Pass
Found field with name 'profile_type' and value 1 Browser linkit_profile.test 56 LinkitProfileUICRUDTestCase->testCreateProfile() Pass

nagy.balint’s picture

nagy.balint commented
Version: 7.x-3.3 » 7.x-3.x-dev
Status: Needs work » Needs review

Maybe now with latest dev?

mr.york’s picture

mr.york commented
Status: Needs review » Reviewed & tested by the community

Works for me. Thank you.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Is this tested when the site is a subdir?