Linking to private files should use 'system/files/' instead of 'sites/*/private/'.

CommentFileSizeAuthor
#2 linkit-private_files_direct_link-2652300-2.patch814 bytesPascalAnimateur

Comments

PascalAnimateur created an issue. See original summary.

PascalAnimateur’s picture

PascalAnimateur CreditAttribution: PascalAnimateur commented
Status: Active » Needs review
StatusFileSize
new linkit-private_files_direct_link-2652300-2.patch814 bytes

Simple patch that fixes the issue in my case.

chrisgross’s picture

chrisgross CreditAttribution: chrisgross commented

This patch works for me, but from what I can tell, the path doesn't need to be absolute since 'system/files' is a valid drupal path.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented
Status: Needs review » Needs work

We need a test for this.

m.ok’s picture

m.ok CreditAttribution: m.ok as a volunteer and commented

The patch works well. But I agree with #3, because now the absolute path may cause other problems, e.g. during migration. Is it possible to use a relative path to system/files for private files?

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Related issues: +#2922306: Direct links to private files are wrong

Ah, I just noticed this issue, but unfortunately after creating an issue of my own:

#2922306: Direct links to private files are wrong

I got thrown off by the title on the issue because it isn't really problem that they are relative, just the way that the relative paths are generated.

The patch over on my issue fixes this problem, but in a way that keeps the private links relative.

Please let me know what you think!

queenvictoria’s picture

queenvictoria CreditAttribution: queenvictoria at Holly commented

I'm using @dsnopek 's fix. Works well.