Needs review
Project:
Linkit
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Jan 2019 at 03:57 UTC
Updated:
24 Sep 2019 at 14:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
anonThis also solves the #2821991: jQuery live function removed in jQuery 1.9
Comment #3
dimiter commentedI have checked the actual difference in the file before and after the patch is applied. There are some changes, however they are only whitespaces (e.g. indenting and newlines) and don't make any functional change to the applied javascript.
So yes, I'm all in for using newer versions of modules, but this will not have any influence on the javascript that is executed.
Besides, it looks like the Better Autocomplete library itself has been abandoned (the website of its developer is currently serving spam content). Also, using jQuery plugins in 2019 is highly frowned upon, as often pure JS implementations are available that are better, faster and more maintained, and do not rely on jQuery (which is still included in D7, but not any more by default in D8). So IMO there should be a story: Replace BAC instead of Update BAC.