The options that are not part of a value or option lists from Mailchimp are not translatable.

The attached patch removed the duplicated code that mapped the choices in the mailchimp_insert_drupal_form_tag function and added a t() wrapper around the value part of the option string.

CommentFileSizeAuthor
#3 3091752-make-options-translatable-2.patch1.65 KBRene Bakx
#2 3091752-make-option-labels-translatable.patch1.65 KBRene Bakx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Rene Bakx created an issue. See original summary.

Rene Bakx’s picture

Rene Bakx
He/Him/Smurf
Primary language Dutch
Location Netherlands
CreditAttribution: Rene Bakx as a volunteer commented
FileSize
3091752-make-option-labels-translatable.patch1.65 KB
Rene Bakx’s picture

Rene Bakx
He/Him/Smurf
Primary language Dutch
Location Netherlands
CreditAttribution: Rene Bakx as a volunteer commented
FileSize
3091752-make-options-translatable-2.patch1.65 KB

Rerolled the patch so radio button options are actually translatable too.

gcb’s picture

gcb
he/him
CreditAttribution: gcb as a volunteer and at ThinkShout commented
Status: Needs review » Postponed (maintainer needs more info)

I haven't worked with translation a lot, but it was my understanding that passing variables into `t('')` was pointless: you should only pass raw text into it. I suppose I can imagine that that is just guidance, and not hard-and-fast, and that in cases like this where the text is coming from an external system but is oft repeated, translation could still be useful. Can you provide any more details about what this achieves, and perhaps instructions for testing out this improvement?