Migrations: Metatag-D7 default configurations [#2563651]

Write Migrate integration for the global configurations to allow for upgrading from 7.x-1.x.

This should convert the "metatag_defaults" table data to the MetatagDefaults config entities for D8.

Comment	File	Size	Author
#33	metatag-n2563651-33.patch	36.15 KB	DamienMcKenna
#33	8.x-1.x: PHP 7.3 & MySQL 5.7, D9.5.5 370 pass, 5 fail
#32	metatag-n2563651-32.patch	36.16 KB	DamienMcKenna
#32	8.x-1.x: PHP 7.3 & MySQL 5.7, D9.5.5 PHPLint Failed
#31	metatag-n2563651-31.patch	33.88 KB	DamienMcKenna
#31	8.x-1.x: PHP 7.3 & MySQL 5.7, D9.5.5 PHPLint Failed
#24	metatag-n2563651-24.patch	32.84 KB	DamienMcKenna
#24	8.x-1.x: PHP 7.3 & MySQL 5.7, D9.5.5 372 pass, 1 fail
#24	metatag-n2563651-24.interdiff.txt	19.11 KB	DamienMcKenna
#22	metatag-n2563651-22.patch	6.56 KB	DamienMcKenna
#22	8.x-1.x: PHP 7.4 & MySQL 5.7, D9.2 392 pass, 2 fail
#22	metatag-n2563651-22.interdiff.txt	633 bytes	DamienMcKenna
#15	metatag-n2563651-15.patch	6.7 KB	DamienMcKenna
#15	8.x-1.x: PHP 7.3 & MySQL 5.7, D8.9.1 361 pass, 2 fail
#15	metatag-n2563651-15.interdiff.txt	3.72 KB	DamienMcKenna
#14	metatag-n2563651-14.patch	5.94 KB	DamienMcKenna
#14	8.x-1.x: PHP 7.3 & MySQL 5.7, D8.9.1 360 pass, 4 fail
#10	metatag-n2563651-10.patch	5.33 KB	DamienMcKenna
#10	8.x-1.x: PHP 7.3 & MySQL 5.7, D8.9.1 359 pass, 6 fail

Issue fork metatag-2563651

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2 hidden branches

2563651-wip

changes, plain diff MR !1

Check out this branch

8.x-1.x

changes, plain diff MR !87

Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

5 September 2015 at 10:44

DamienMcKenna created an issue. See original summary.

Comment #2

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 28 January 2017 at 02:32

Parent issue:

#2563617: Plan for Metatag 8.x-1.2 release

The 1.0 release is being bumped up, so the everything else is being put on the back burner for now.

Comment #3

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 28 January 2017 at 03:10

Postponing until after 1.0.

Comment #4

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 28 January 2017 at 03:11

Status:

Active

» Postponed

Comment #5

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 31 January 2017 at 22:41

Status:

Postponed

» Active

8.x-1.0 is out, so this is fair game again.

Comment #6

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 18 February 2019 at 18:35

Issue tags:

+migrate-d7-d8

Comment #7

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 3 April 2019 at 18:25

Title:

Migrations: global configurations

» Migrations: default configurations

https://thinktandem.io/blog/2018/07/24/writing-a-custom-drupal-8-module-...

Comment #8

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 3 April 2019 at 18:26

Comment #9

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 3 April 2019 at 18:27

Title:

Migrations: default configurations

» Migrations: Metatag-D7 default configurations

Comment #10

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 25 June 2020 at 17:38

File	Size
metatag-n2563651-10.patch	5.33 KB
8.x-1.x: PHP 7.3 & MySQL 5.7, D8.9.1 359 pass, 6 fail

Work has started on this, see the issue fork for details; I've also attached it as a patch file to avoid accidental loss.

Comment #11

10 July 2020 at 17:41

DamienMcKenna credited alisonjo315.

Comment #12

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 10 July 2020 at 17:41

Some suggestions of things to look at from @alisonjo315 (her comments):

d7_view_modes - very simple example of using static_map, no dependencies/connections on other migrations.
d7_field has example usage of "constants" -- and an explanatory code comment about "translatable".
d7_field_formatter_settings goes one level up I think -- two migration_lookup uses, to the field migration and view mode migration -- and has examples of setting local variables (I can't remember if that's the actual term, sorry if it isn't).

Comment #13

15 July 2020 at 17:47

DamienMcKenna opened merge request !1

File	Size
metatag-n2563651-14.patch	5.94 KB
8.x-1.x: PHP 7.3 & MySQL 5.7, D8.9.1 360 pass, 4 fail

Comment #15

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 10 August 2020 at 14:48

File	Size
metatag-n2563651-15.interdiff.txt	3.72 KB
metatag-n2563651-15.patch	6.7 KB
8.x-1.x: PHP 7.3 & MySQL 5.7, D8.9.1 361 pass, 2 fail

Everything so far, not sure if anything was changed from #14.

Comment #16

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 10 August 2020 at 14:48

Status:

Active

» Needs review

So yes, some changes were made from #14 ;-)

Comment #17

10 August 2020 at 15:00

The last submitted patch, 14: metatag-n2563651-14.patch, failed testing. View results

Comment #18

10 August 2020 at 15:02

The last submitted patch, 10: metatag-n2563651-10.patch, failed testing. View results

Comment #19

10 August 2020 at 15:02

Status:

Needs review

» Needs work

The last submitted patch, 15: metatag-n2563651-15.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #20

bob.hinrichs CreditAttribution: bob.hinrichs commented 18 December 2020 at 23:10

FYI, I tried this out. I do not know if it is finished enough to try. But the sourceid2 length for the migrate map table created this error:
String data, right truncated: 1406 Data too long for column 'sourceid2' at row 1: INSERT INTO {migrate_map_upgrade_d7_metatag_default} ("source_ids_hash", "sourceid1", "sourceid2", "source_row_status", "rollback_action", "hash") VALUE
S (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5)

Comment #21

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 18 February 2021 at 16:06

Issue summary:

View changes

Comment #22

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 December 2021 at 21:19

Status:

Needs work

» Needs review

File	Size
metatag-n2563651-22.interdiff.txt	633 bytes
metatag-n2563651-22.patch	6.56 KB
8.x-1.x: PHP 7.4 & MySQL 5.7, D9.2 392 pass, 2 fail

Remove the workaround for D8.

Comment #23

2 December 2021 at 21:32

Status:

Needs review

» Needs work

The last submitted patch, 22: metatag-n2563651-22.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #24

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 30 June 2023 at 18:09

Status:

Needs work

» Needs review

File	Size
metatag-n2563651-24.interdiff.txt	19.11 KB
metatag-n2563651-24.patch	32.84 KB
8.x-1.x: PHP 7.3 & MySQL 5.7, D9.5.5 372 pass, 1 fail

6 files were hidden/shown/deleted

File	Size
metatag-n2563651-10.patch	5.33 KB
8.x-1.x: PHP 7.3 & MySQL 5.7, D8.9.1 359 pass, 6 fail
metatag-n2563651-14.patch	5.94 KB
8.x-1.x: PHP 7.3 & MySQL 5.7, D8.9.1 360 pass, 4 fail
metatag-n2563651-15.interdiff.txt	3.72 KB
metatag-n2563651-15.patch	6.7 KB
8.x-1.x: PHP 7.3 & MySQL 5.7, D8.9.1 361 pass, 2 fail
metatag-n2563651-22.interdiff.txt	633 bytes
metatag-n2563651-22.patch	6.56 KB
8.x-1.x: PHP 7.4 & MySQL 5.7, D9.2 392 pass, 2 fail

WIP. Refactoring some of the transformation logic.

Comment #25

30 June 2023 at 18:16

Status:

Needs review

» Needs work

The last submitted patch, 24: metatag-n2563651-24.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

CreditAttribution: DamienMcKenna at Mediacurrent commented 30 June 2023 at 20:17

A suggestion from benjifisher in Slack - use the entity destination plugin, like Menu and Block use.

Comment #31

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 30 June 2023 at 20:20

Status:

Needs work

» Needs review

File	Size
metatag-n2563651-31.patch	33.88 KB
8.x-1.x: PHP 7.3 & MySQL 5.7, D9.5.5 PHPLint Failed

Changing the migration plugin to call them "defaults", and using the entity destination plugin.

Comment #32

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 1 July 2023 at 09:36

File	Size
metatag-n2563651-32.patch	36.16 KB
8.x-1.x: PHP 7.3 & MySQL 5.7, D9.5.5 PHPLint Failed

WIP

Comment #33

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 1 July 2023 at 10:06

File	Size
metatag-n2563651-33.patch	36.15 KB
8.x-1.x: PHP 7.3 & MySQL 5.7, D9.5.5 370 pass, 5 fail

PHP 7 doesn't allow for multiple return types.

Comment #34

1 July 2023 at 10:15

Status:

Needs review

» Needs work

The last submitted patch, 33: metatag-n2563651-33.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Migrations: Metatag-D7 default configurations

Issue fork metatag-2563651

Comments

Related issues

Referenced by