Creating events with a repeated date is good stuff !
When an event is created with a repeated date all dates appear in the view.
But then i see three problems :
When an event without unique node occurrences, is created and when we modify the date, we have the following problems :
- the rule doesn't appear any more and the event only appears in the view at the first date.
- in the edit page, the "repeat" check box is dis enabled and it is not possible to check it, and this message appear : "Unable to repeat a currently repeated occurrence."
And when an event with unique node occurrences needs to be edited, the save button has no effect.
Comment | File | Size | Author |
---|---|---|---|
#7 | 2699899-date-repeat-fix-7.patch | 818 bytes | SocialNicheGuru |
Comments
Comment #2
mpotter CreditAttribution: mpotter at Phase2 commentedThere is an App in the Apps/Open Atrium/Core Addons area called "Open Atrium Repeating Date" (or something like that) which adds a checkbox to your date field for a new event to determine if it should create unique nodes for each instance or not.
Comment #3
ohmdesbois CreditAttribution: ohmdesbois commentedThe apps located at admin/apps/openatrium/oa_date_repeat is enabled.
But when an event is created with "unique node occurrences" checkbox unchecked, and we edit and modify the date, we have the following problems :
- the rule doesn't appear any more on the event header and the event only appears in the view at the first date.
- in the edit page, the "repeat" check box is disabled, it is not possible to check it, and this message appear : "Unable to repeat a currently repeated occurrence."
- when an event is created with "unique node occurrences" checkbox checked and we need to edit it, the save button has no effect.
Comment #4
mpotter CreditAttribution: mpotter at Phase2 commentedYep, I see that. It seems that the oa_date_repeat module is actually breaking the behavior of non-unique events. If you disable the app then repeating events can be edited normally. Not sure what caused this to break as we haven't done anything different in the oa_event module in a while and this used to work, but will add it to the backlog. Patches are welcome if somebody else sees how to fix this in oa_date_repeat.
Comment #5
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedI can confirm this
Comment #6
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedI am attaching a patch.
for some reason this line did not return empty
if (empty($form['#node']->field_oa_date_repeat_source_ref)
I am on PHP 5.6.30-12~ubuntu14.04.1+deb.sury.org+1 (cli)
also had to make sure that if there was no repeat rule, then 'Save' was not altered.
Comment #7
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedThe patch only addresses a subset of the issue:
1) allow the save button to work if you cannot open the repeat rule
2) replace isset with
!empty
so that the condition works properlySo if it is a repeat rule and each occurrence is a different node, then remove the repeat option because it can no longer be edited.
Comment #8
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedThis issue speaks to the date_repeat and fullcalendar integration