Problem/Motivation

Not working on Drupal 10

Steps to reproduce

1. Create 1 View with 2 Blocks with Ajax enabled.
2. Create QuickTabs with 2 tab, each of which would have 1 of above blocks.
3. Place QuickTabs created above on Block Region.
4. Load tab using TwigTweak
5. Fist tab is loaded okay, but another tab never got loaded.
if Ajax enabled, 2nd tab never loaded, if not ajax enabled, page got redirected to somewhat strange URL.

CommentFileSizeAuthor
#11 quicktabs-theme-wrappers-3355556-0.patch1.25 KBbsfajardo
#3 tab2.png7.2 KBviren18febs
#3 tab1.png10.69 KBviren18febs

Issue fork quicktabs-3355556

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Austin986 created an issue. See original summary.

viren18febs’s picture

viren18febs commented
Assigned: Unassigned » viren18febs

Checking the issue!

viren18febs’s picture

viren18febs commented
Assigned: viren18febs » Unassigned
Status: Active » Needs review
StatusFileSize
new tab1.png10.69 KB
new tab2.png7.2 KB

Hi Austin986,

I have checked the issue in Drupal 10.1 & followed the steps for reproduce. I have placed the Quick tab block with TwigTweak. but it's working for me as per expected. I have attached the images for reference, please review.

themasoodahmad’s picture

themasoodahmad commented

Same for me, it is not working. The second tab is not showing up there. My Drupal version is 10.1.4.

nmangold’s picture

nmangold commented

I could not reproduce this issue either.

nmangold’s picture

nmangold commented
Priority: Critical » Normal
drupgirl’s picture

drupgirl commented

Same. To reproduce you have to have ajax enabled, which makes me think this is a duplicate of 2926105.

If views use ajax then this module doesn't work.

The path redirect is quicktabs/nojs/[view_name]/1, quicktabs/nojs/[view_name]/2, etc.

jonodunnett’s picture

jonodunnett commented

Some problems for me (NOW RESOLVED: SEE UPDATE) after update to D10 when one of my tabs contains a Webform.

- If Quicktab setting is to use Ajax, then the tabs show up but the content does not load properly when clicked ("Loading content..." message forever.)
- If Quicktab setting is to NOT use Ajax, then none of the tabs show up (not even the tab names).

Functionality returns if I delete the Webform Quicktab.

UPDATE: The webform had some css added via the webform configuration page, and this was failing to load. The simple solution was to remove this css (which can be included in the theme css instead). All tabs now working both in Ajax and non-Ajax mode.

fgvlasov’s picture

fgvlasov commented

Also not showing new Blocks created from Quicktabs.
Drupal core 9.3.6
ebt_core 1.4.12
Only first Tabs (core)

nikolay shapovalov’s picture

nikolay shapovalov commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs tests

It would be great to have tests to reproduce this issue.

bsfajardo’s picture

bsfajardo commented
StatusFileSize
new quicktabs-theme-wrappers-3355556-0.patch1.25 KB

I was facing the same issue. In my case, the problem seemed to be with #theme_wrappers not being rendered correctly. I replaced two of these wrappers with #prefix and #suffix in the render array, and the issue was fixed. Not sure yet what caused the original wrappers to stop working, or what is missing for them to work properly in Drupal 10.

Patch attached.

themasoodahmad’s picture

themasoodahmad commented
Issue summary: View changes
Status: Needs work » Fixed

The was resolved while debugging the twig code, the wrapper div was open but not closed somewhere. If anyone face problem like this, please do check the opening and closing divs.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.