Problem/Motivation

The dropdown doesn't toggle as it should as it is using "data-toggle" instead of "data-bs-toggle" .
in line https://git.drupalcode.org/project/radix/-/blob/5.0.x/src/components/nav... .

Steps to reproduce

Use some vbo views.

Proposed resolution

lazy diff:

-   <button type="button" class="btn btn-sm btn-outline-dark dropdown-toggle {{ split ? 'dropdown-toggle-split' }}" data-toggle="dropdown">
+   <button type="button" class="btn btn-sm btn-outline-dark dropdown-toggle {{ split ? 'dropdown-toggle-split' }}" data-bs-toggle="dropdown">

Issue fork radix-3241198

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aleix created an issue. See original summary.

ckng’s picture

ckng
Primary language English
CreditAttribution: ckng at O8 commented
Status: Active » Closed (works as designed)

5.0.x branch is for Bootstrap 5.x. data-toggle is < 5.x.

aleix’s picture

aleix CreditAttribution: aleix commented
Status: Closed (works as designed) » Needs review

Maybe I am wrong but... it is reported in 5.0.x-dev. As you said data-toggle is for Bootstrap < 5.x, and from bootstrap >= 5.x is data-bs-toggle. So the above diff fixes what we are saying.

aleix opened merge request !13

  • ckng committed 4cc3d8a on 5.0.x authored by aleix 
    Issue #3241198 by aleix, ckng: dropdown links not toggled
ckng’s picture

ckng
Primary language English
CreditAttribution: ckng at O8 commented
Status: Needs review » Fixed

Thanks for the patch.
Right, I interpreted it the other way.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Endika Melero made their first commit to this issue’s fork.

Endika Melero opened merge request !47

lordgretix’s picture

lordgretix CreditAttribution: lordgretix commented

As a summary, the problem came back at some point so here is once more the fix to it. Can you review it @ckng

Also, I am seeing that maybe I should have update the issue before creating the merge request? Please correct me if I did it in the wrong way.