Problem/Motivation

Bootstrap 5 favors the use of "end" and "start" instead of "right" and "left on utility classes. This is generally intented to avoid using concepts tied to RTL languages, and replicates the semantics of Flexbox, amongst others, where "end" and "start" are not absolute but relative to the direction of the flow.

There are some instances of .mr-auto still on Radix 5.x-dev, most notably the class that separates the navbar-left and navbar-right regions on the navigation area on page.twig:


    {% block left %}
      {% if page.navbar_left %}
        <div class="mr-auto">
          {{ page.navbar_left }}
        </div>
      {% endif %}
    {% endblock %}

This issue could also check for other missing utility classes (padding-left, etc)

Issue fork radix-3281660

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

idiaz.roncero created an issue. See original summary.

idiaz.roncero’s picture

Issue summary: View changes

idiaz.roncero’s picture

Title: .mr-auto and .ml-auto classes should use "end" and "start" instead » .mr-auto and similar classes should use "end" and "start" instead
Issue summary: View changes
idiaz.roncero’s picture

I did a quick search and replace for .mr, .ml, .pr and .pl classes and found four occurrences.

Also, I found a small typo on <img src="{{ src }}" width="{{ width|default(30) }}" {{ height_attr }}" alt="{{ alt|default('') }}" class="mr-2" />, extra quotes after {{ height_attr }}

idiaz.roncero’s picture

Status: Active » Needs review

doxigo made their first commit to this issue’s fork.

  • doxigo committed 3696502 on 5.0.x authored by idiaz.roncero
    Issue #3281660 by idiaz.roncero: .mr-auto and similar classes should use...
doxigo’s picture

Status: Needs review » Fixed

Yet again, thanks for the contribution Díaz, merged to dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.