Store Front

here is the output from a automatic project review by ventral.org
http://ventral.org/pareview/httpgitdrupalorgsandboxdudenhofer1370548git

@klausi sorry my bad

@Ciraxis: please do not post the full output of pareview.sh, you can attach it in a text file.

There still seems to be a minor css-coding standards issue in css/screen.css line 780 -> 782.
Selectors should be on one line, as far as I know.

Apart from that, couldn't find anything worth noting.

Being relatively new to the Drupal scene myself, I'm fairly certain that I can't spot all the possible issues (hook vs another hook stuff, for example), but pareview is clean and I couldn't find any real issues reading through the code manually.
Not entirely certain if I should say be the one to say it, but to me this looks RTBC.

Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

• your code should be in the root of the repository, there should be no additional storefront subfolder.
• Remove .DS_Store from the repository in storefront/css
• "<a href="' . base_path() . '">Continue Shopping</a>": do not create link markup yourself, use l() instead. And all user facing text should run through t() for translation.
• all function should start with your theme's name to avoid name collisions.
• jquery.formalize.js: appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms. The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.
• vertical-tabs.js: this is part of drupal core, no?

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

• You don't seem to have any CSS reset functionality setup? http://meyerweb.com/eric/tools/css/reset/index.html
• PIE.htc is 3rd party code and as mentioned above by klausi 3rd party code is not generally allowed on Drupal.org and should be deleted.
• You should avoid putting html tags inside t() function whenever possible.
• There is some unnecessary repetition of code in your theme-settings.php file, use variables instead. For example this on lines 187 and 216:
  

  '#options' => array(
          '0' => t('Use CSS'),
          '3' => t('3 Columns'),
          '4' => t('4 Columns'),
          '5' => t('5 Columns'),
          '6' => t('6 Columns'),
          '7' => t('7 Columns'),
          '8' => t('8 Columns'),
          '9' => t('9 Columns'),
          '10' => t('10 Columns'),
          '11' => t('11 Columns'),
          '12' => t('12 Columns'),
        ),

There are still errors when the branch is run through Ventral:

1) Function names should have storefront namespace (the name of the theme) in theme-settings.php.
2) Space in theme-settings.php on line 392 used in t() $string argument.
3) Absent style definition in screen.css (line 794).
4) Spaces missing for operator statements (e.g. "=", ".=" etc.) in template.process.inc. (line 322 & 512).
5) Line too long in SFSTARTER.info.txt (line 2). Break it into multiple lines.

Review bonus.

It looks like repond.js is also third party code. I found this module (http://drupal.org/project/respondjs) which requires admins to download the js file from github into the libraries folder, and reportedly adds it at the most appropriate time.

Other than that, this theme looks great! I tested it on my work and home computers and on my android phone, and didn't find any problems. I didn't see any in the code you wrote either, in fact it was extremely readable!

Looks good to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Please take a moment to make your project page follow tips for a great project page.
Meanwhile there were some enhancements of drupalcs, and it's complaining about some minor issues again ;-)

Nice thing! Also for me this is ready, so..

Thanks for your contribution and welcome to the community of project contributors on drupal.org. :)

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.