Before/After image formatter

Hi

Seems to be well written and you have already fix the coding issues.

Anyway we do really need more hands in the application queue and highly recommend to get a review bonus so we will come back to your application sooner.

Check : http://drupal.org/node/1011698

See also #1410826: [META] Review bonus

Thanks,

The README.txt seems to be copied from field_group.

You added jquery.beforeafter-1.4.js directly to your module. I think that should not be done with third party libs.

As long as your not uploading the jquery library to drupal.org and make use of the libraries api that shouldn't be a problem, I think

oh sorry I missed the "non-commercial" part, yes, your right in that case it's problematic
If you re-write it and planning just to use it in this project (nonewhere else then drupal.org) you can also directly push it into the git repo without libraries stuff

corrected git url

Thanks for your reviews, just make sure that you pick applications that did not get a review in a long time.

Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: ...pal-7/sites/all/modules/pareview_temp/test_candidate/beforeafter.module
  --------------------------------------------------------------------------------
  FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   12 | ERROR | Do not use t() in hook_menu()
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

1. LICENCE.txt: remove that, all code on drupal.org is automatically GPLv2, you cannot license other terms here
2. README.txt: link is missing where to download the required jquery plugin.
3. beforeafter.js: is this the third party jquery plugin? Then it needs to be removed, as it is not GPL compatible.
4. If you want to be sure that the jquery library is present you should implement hook_requirements().
5. beforeafter_settings_get_value(): why do you need that function? You can just use variable_get() with default values anyway?

Otherwise looks nearly ready to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Goog work geertvd
I found some issues:

• In beforeafter_uninstall() please use the variable_del() function instead the SQL query.
• Add the full-stop in beforeafter.module line 4.
• In the master branch, clean the README.txt file, please check http://drupal.org/node/1127732.

correct git url

In beforeafter_uninstall() please use the variable_del() function instead the SQL query.
I don't think that it's important how variables are deleted, (as long they are deleted).
Some modules make a huge use of variables and also create them with dynamic names, therefore it's much harder to delete them all with variable_del().

1. Always begin comments uppercase and end with fullstop. There are also some grammatical issues, but nothing serious
2. Some more inline-comments wont hurt you ;-)
3. dsm($items); not good, not good, make always sure to remove all debugging stuff before doing a commit, this would brake a site down if devel is not installed

Besides this, I think this one looks quite good!

had a second look, now I can't locate them either xP
maybe I'm just too tired

Thanks for your contribution, geertvd! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.