[D7] Mailcheck

welcome,

Automated reports do not through a single error, good job ;)

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

Manual review :-

• mailchecker.module:- Line 29, Implements is used for a hook. mailchecker_conf() is not a hook, so use callback or function in comments. Refer Doxygen and comment formatting conventions.
• Correct function commenting at lines 133, 153, 186. Refer above specified link.
• mailchecker.module:- Line 140, 172 Use t() to wrap messages.
• mailchecker.module:- Line 183 @param and @return are used for documenting functions. @static is not advisable.

No issues on http://ventral.org/pareview/httpgitdrupalorgsandboxelvar1504456git.

Feedback:
- I downloaded the module and installed it. When I go to /admin/config I cannot find Mailchecker to access the admin page. However, directly accessing admin/config/mailchecker works fine.
- First when I read the readme.txt file, I did not fully understand for what the module is for. I understood it when reading Line 14 of readme. Why not put this to the head of the readme. I first assumed it's kind of a "regex" validator for emails.
- You also ship mailcheck.js with the module altough in the installation instruction it say you have to download it from github. Why is that? (I understood it, that the script in the module is kind of the bridge between drupal and mailchecker.js)
- When saving the config page I received this "Notice: Undefined index: webform in mailchecker_conf_submit() (line 160 of /Users/fischerlukas/Sites/drupalmonitor7/drupal-7.12/sites/all/modules/mailchecker/mailchecker.module)." I changed source path.
- One minor thing I run into. The module is called mailchecker. When downloading the js from github it's called https://raw.github.com/Kicksend/mailcheck/master/src/jquery.mailcheck.js -> MAILCHECK.js withouth ER. I somehow assumed that the libaries folder is also called mailchecker as the module, but in the proposed source path it's also mailcheck with er. This maybe sounds stupid but I almost stopped using the module because I could not make it run right away, just because of a stupid misspelling of folders.

In the end, it worked on my side.

Sorry for the delay. Make sure to finish your review bonus, otherwise reviews will take a long time.

Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. the README.txt says this works for fields, where is that implemented?
2. mailchecker.js: this should use Drupal.behaviors, right? http://drupal.org/node/756722
3. mailchecker_conf_submit(): do not access the raw $form_state['input'], use $form_state['values'] instead.
4. mailchecker_conf(): you could use system_settings_form() to save your settings, then you also don't need your submit callback.

But otherwise it looks nearly ready.

manual review:

1. mailcheck_conf_validate(): still using raw $form_state['input'], use $form_state['values'] instead.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Yes, but the function mailcheck_conf_validate() still uses it wrongly.

And marked #1609068: [D7] e-Commerce Mailcheck as duplicate.

function skaheThatShit(el)

Can we have a better name for this please?

shakeEffect() or animateShake() perhaps.

No objections in more than a week, so ...

Thanks for your contribution, Elvar!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.