DESCRIPTION AND FEATURES
The Content Share module is designed to serve a Drupal site's content and custom data via a URL. A content consumer can initiate a transfer by a URL call. It can be done in a client or in a browser.
The URL on the host site takes intuitive and flexible query requests. Here is an example: www.YourDrupalSite.com/api/content.json&before=2012-04-12&type=page
This query will return all content of type "page" created on YourDrupalSite before 2012-04-12, provided you have access to it.

Authentication is optional. It can be required or disabled by the admin of the host site (YourDrupalSite). If Authentication is “on” the consumer client will be required to provide a login/password pair. These can be obtained by registering at the host Drupal site (YourDrupalSite). If Authentication is “off” content will be served to the anonymous user with anonymous permissions. See "AUTHENTICATION" section below on details of how to authenticate a client.

Admin settings allow to choose what content types and fields will be served.

Content Share returns JSON or XML, or other formats enabled in the Services module. Content Share extends Services to create an API endpoint and to format output. It handles input parsing, security, data querying, and other aspects of serving content via a URL.

Content Share depends on Services, Content, Chaos tools, Apachesolr.

The Content Share development is supported as part of www.SBA.gov site development at www.REIsystems.com.

The features is what makes it different from other content API projects. This module has several functionalities that make it different from other available APIs for content sharing across sites. The functionalities of this module currently include:
1. Intuitive and Flexible URL Query language
2. Drupal Session Authentication or Anonymous Querying depending on admin settings at ./admin/settings/content_share
3. User access to the API controlled by role for authenticated users
4. Admin settings of what content types and fields to expose to the consumer
5. Usage Logs and Stats
6. Solr Search Integration
7. Error Reporting and Tracking
8. Security Heuristics for Query Handling
9. Batch download for big data
10. Size of download estimate

A link to your project page:
http://drupal.org/sandbox/krylov/1530604

A direct link to your git repository:
http://drupalcode.org/sandbox/krylov/1530604.git

Currently it is a Drupal 6 module.

Reviews of other projects:
https://drupal.org/node/1248326#comment-6231854
http://drupal.org/node/1591870#comment-6239566
http://drupal.org/node/1570804#comment-6239628

Reviews of other projects, round 2:
http://drupal.org/node/1678248#comment-6273574

Comments

krylov’s picture

krylov commented
Issue summary: View changes

changed the Git Repo link

d2ev’s picture

d2ev commented

Hi krylov
It is a good module. You have some errors in ventral:
http://ventral.org/pareview/httpgitdrupalorgsandboxkrylov1530604git

d2ev’s picture

d2ev commented
Status: Needs review » Needs work
krylov’s picture

krylov commented

Thanks, D2ev. I rolled out a 1.1 version with additional features and UI. Worked through the ventral formatting errors. Most of them appear to be in the third party Solr library I am including.

patrickd’s picture

patrickd commented

The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.

Don't forget to switch back to needs review when your ready

krylov’s picture

krylov commented
Status: Needs work » Needs review
krylov’s picture

krylov commented

Thanks, patrickd. The library is there for reference reasons. I am actually depending on Apachesolr which in turn uses the Solr library.

krylov’s picture

krylov commented
Priority: Normal » Major
krylov’s picture

krylov commented
Priority: Major » Critical
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

krylov’s picture

krylov commented

Thanks, Klaus. I will look in the queue for a project to review. Also, please feel free to suggest one.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Just start with the critical ones or the old ones.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

edited link to Git Repo

krylov’s picture

krylov commented
Issue tags: +PAreview: review bonus

Thanks. Reviewed Anonymous File Sharing

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue tags: -PAreview: review bonus

Removing review bonus tag, you have to do 3 manual reviews of other projects in order to earn it. See #1410826: [META] Review bonus. Thanks for starting though! :-)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

Review bonus added

krylov’s picture

krylov commented
Issue summary: View changes

+1 review

krylov’s picture

krylov commented
Issue tags: +PAreview: review bonus

Thanks for pointing this out. Now there are 3:)

misc’s picture

misc commented
Assigned: Unassigned » misc

Assigning this to me to do a manual review.

misc’s picture

misc commented
Assigned: misc » Unassigned
Status: Needs review » Needs work
Issue tags: -PAreview: review bonus

Here is my manual review:

Branches
You are not following the branch naming convention - I reviewed 6.x-1.1, becuase that one seems the newest one, it should be named 6.x-1.x. Please see release naming conventions and creating a branch in git.
cs_solr
You have a sub module, cs_solr, should thsi be part of the review?
Inline comments
Following doxygen standards inline comments start with //, not //***. Also do not use capitals for comments
All caps descriptions
Do not use All caps in descriptions
Suggestion: Move html to tpl
You output html in the code, it would be better if you use a tpl-file and theme hooks.
Proper indenting
Seems that you are mixing a lot of coding styles, you should use drupal standards, two spaces for indenting
Automtic review
See automatic review for coding style errors: http://ventral.org/pareview/httpgitdrupalorgsandboxkrylov1530604git-6x-11

There are some more stuff, but this should be enough to start with.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1635464
Project 2: http://drupal.org/node/1556354

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

krylov’s picture

krylov commented

Thank you for the clarification. I am sorry for opening the second application before the first one was promoted to full project. Please keep this application, Code Migrate http://drupal.org/node/1635464, running. It has already been reviewed.

Close the other one,
http://drupal.org/node/1556354

Robin Millette’s picture

Robin Millette commented
Status: Needs work » Closed (duplicate)

swapping...

Robin Millette’s picture

Robin Millette commented
Issue summary: View changes

+1 review

krylov’s picture

krylov commented
Issue summary: View changes

review+

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Content Share » [D6] Content Share
Priority: Critical » Normal