[D7] Code Migrate

Manual review:
--------------------------------------

1. Branch name should follow Release naming conventions, eg:6.x-1.x
2. Remove branch 6x-1.1
3. Add git link as well as the project link
4. Can you not using capitalized words for descriptions?
5. Instructions for installation and using is welcome.

Hi,

You have to correct your code with global recommandation.
You can use the tool in this URL : http://ventral.org/pareview

For example, all comments must be finished by a point, the comments function must specify "Implements" word instead of "Implementation".

Be careful about indentation in for() and if() blocks.
You have to use space for indentation and not tabs (line 44 and 45).

Don't use the t() function for menu item title, the system will add this for you.

Try to let some blank lines between instructions (for example, line 151 to 184).

Regards,

Assigning to me to do a manual review.

Automatic review: http://ventral.org/pareview/httpgitdrupalorgsandboxkrylov1635422git

Manual review:

I can see that this would be quite heavy on memory on sites with al lot of modules, have you done some tests for that? Have you been thinking on using batch api?

1 - Modules could be installed in other folders, so you should not count on it being in sites/all - it seems what you are looking for is something like: drupal_get_path('module', 'code_migrate'), or?
2 - Couple of dozens of seconds would lead to time outs on many servers - many developers do not develop locally (but they should...). I tried the module locally on a normal drupal 6 built for an customer and got error becuase of maximum execution time, I even tried to raise it to 120 seconds, but still got an timeout. That is why I ask about batch api. And yes I understand the purpose of the module...

Also I would suggest that you add a check all option for the module pageI tested it out, and you should add an option to mark all checkboxes.

1 - Ah ok, misunderstand you usage there, but why do you need this one to be a variable then? And how about if you migrate from a profile , like Pressflow to just drupal 7?
2 - 60 modules is not so much on a regular drupal 6 site.

However, this issues should not be something that stops it for being RTBC.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1635464
Project 2: http://drupal.org/node/1556354

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

swapping...

RTBC as set in #1635464-14: [D7] Code Migrate.

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 6.x-1.x branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. please fix all the coding standard errors.
2. do not use all upper case sentences on your project page, very hard to read. See also http://drupal.org/node/997024
3. what are the differences to the coder upgrade module? why can't you incorporate your code into that existing project? Please add a note about that to your project page and README file.
4. code_migrate.module: do not include PHP files globally if they do not contain hooks. Include them only in functions when you actually need them.
5. code_migrate_settings(): hook_settings() does not exist. See http://drupal.org/node/1354#forms on how to document forms.
6. "Implements of hook_perm()." should be "Implements hook_perm()."
7. "$form['remote_drupal_server']": all variables defined by your module have to prefixed with your module's name to avoid collisions with other modules.
8. do not use all upper case words, use standard English capitalization in all your user interface strings.
9. code_migrate_init(): why do you need that? The path is only accessible by authenticated users anyway, so there is no page caching?

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Thanks for your contribution, krylov!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on irc in #drupal-contribute. So, come hang out and stay involved! Thanks again, and good luck! :)

@Mitchell, you just fixed an application that was RTBC'd by the applicant himself..
please pay more attention on that next time

@patrickd: no, no. I was going off of #14. None the less, I'll join #code-review now to receive my proper chiding if you're available ;)

maybe later ;-)

everyone gets this at the moment, probably site-maintenance.