[D7] Mica

1.Please provide the git link corresponding to non maintainer as "http://git.drupal.org/sandbox/cthiebault/1678054.git" in the issue summary.
2.Please review your project using Coder module and see the automated ventral code review here.
Manual review:
1.Remove
project = "mica"
version = "7.x-1.4.2"
datestamp = "1341932991"
as added by drupal.org refer http://drupal.org/node/542202.
2.In install File call the hook_unistall to configure the original settings of "search_api_index" when the module is uninstalled.
It is strongly recommended that you take part in the review bonus program, otherwise you will not get reviews of your code for several weeks. So make sure to review three project applications to get your project reviewed.

you need to tag it properly

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

• The "?>" PHP delimiter at the end of files is discouraged, see http://drupal.org/node/318#phptags
  

  ./extensions/mica_studies/mica_studies.strongarm.inc
  

• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  ./extensions/mica_datasets/css/prettify.css:                                                ASCII text, with very long lines, with no line terminators
  ./extensions/mica_relation/includes/mica_relation.entity.inc:                               PHP script, ASCII text, with CRLF line terminators
  ./extensions/mica_node_reference_field/mica_node_reference_field.module:                    PHP script, ASCII text, with CRLF line terminators
  extensions/mica_relation/includes/mica_relation.entity.inc
  extensions/mica_node_reference_field/mica_node_reference_field.module
  

• Remove all old CVS $Id tags, they are not needed anymore.
  

  extensions/mica_core/js/jquery.tooltip.min.js:9: * $Id: jquery.tooltip.js 5741 2008-06-21 15:22:16Z joern.zaefferer $
  extensions/mica_core/js/jquery.tooltip.js:9: * $Id: jquery.tooltip.js 5741 2008-06-21 15:22:16Z joern.zaefferer $
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. remove COPYRIGHT.txt, all code on drupal.org is automatically GPL and packaged downloads will get an extra license file added.
2. remove all copyright headers from your files, you can give credit in README.txt
3. node_reference_block.module: do not use module names that are not prefixed with your namespace, that can easily lead to name collisions.
4. jquery.tooltip.js: appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms. The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.
5. Drupal code sniffer took forever to check your whole project, so I suggest that you check your modules individually for coding standards. As far as I can see there no major issues from the samples I took a look at.
6. "if (!is_null($relation)) return NODE_ACCESS_DENY;": Inline control structures are not allowed.
7. mica_relation_form_alter(): the #markup looks vulnerable to XSS exploits if the relation label is user provided input. Make sure to sanitize that, see http://drupal.org/node/28984 . This should run through t() anyway, where you can use "@" placeholders that will sanitize variables for you.

The security issue is a blocker, otherwise this looks nearly ready. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

don't forget to switch back to needs review when you'r ready

manual review:
still quite some coding standards errors, see attachment for some examples.

But that are no blockers, so I think this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Add review http://drupal.org/node/1706546#comment-6294536

nope, looks good! Sorry for the delay!

Thanks for your contribution!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.