The no_field_markup module is a small module which removes the

elements around a Field on output. In addition, it kicks away the label too.
You can control this possibility for each field.

Have a look of this example:

<div class="field field-name-field-firstname field-type-text field-label-above">
	<div class="field-label">Firstname:</div>
	<div class="field-items">
		<div class="field-item even">Dan</div>
	</div>
</div>

is now:

Dan

thank to this module, you have now a smarter domtree and as a "hardcore" themer more flexibility.

Project Link: http://drupal.org/sandbox/moert/1744508

This module is developped for Drupal 7

Git Access: git clone --recursive --branch 7.x-1.x moert@git.drupal.org:sandbox/moert/1744508.git
Git Repo: http://git.drupal.org/sandbox/moert/1744508.git

CommentFileSizeAuthor
#5 remove-line-53_1747854_5.patch539 bytesANDiTKO
no_field_markup.gif8.66 KBmoertle

Comments

Milena’s picture

Milena commented

While waiting for manual review please, correct issues found by automated review tool:
http://ventral.org/pareview/httpgitdrupalorgsandboxmoert1744508git

I am also wondering how your module differs from http://drupal.org/project/semantic_fields?

We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

moertle’s picture

moertle commented

Hi Milena,

first of all, thank you for the link to review a drupal.org projects online. The issues are fixed meanwhile.

I know the project semantic_fields, it inspired me to create the module no_field_markup. Semantic Field is nice, but for some users, it has to much configuration possibilities, if a user only want to remove and not edit the markup around the fields, this module is too big.

Exactly for this users, I have optimized my module: it's small, no overhead and does the job.

jrsinclair’s picture

jrsinclair commented
Status: Needs review » Reviewed & tested by the community

Hi @moertle, I like the idea of this module, and your justification makes sense to me. Just one tick-box to remove a lot of extra markup.

There are a couple of things you could do to make it easier for reviewers to get access to your code:

  1. Change the Git Access link in your issue summary to http://git.drupal.org/sandbox/moert/1744508.git
  2. Remove the master branch now that you've made the 7.x-1.x branch the default.

Otherwise the module seems to work as advertised. Simple and effective.

moertle’s picture

moertle commented

hi jrsinclair,

thank you for the hints.
I removed the master branch and updated the issue summary too.

ANDiTKO’s picture

ANDiTKO commented
StatusFileSize
new remove-line-53_1747854_5.patch539 bytes

Hello,

I tested your module and its working perfectly and as expected.

You could change the checkbox's title. So it start with a capital letter like this:
Change

do not write drupal standard markup around the field

to

Do not write drupal standard markup around the field

I think this was mentioned in the Doxygen and comment formatting conventions. All the other fields start with a capital letter, yours must too ;)

Your code is nice short, but im not sure that this is enough for promoting your account and giving you full project permissions. Its looking clean and passes the automatic code checkup. After checking up manually your code i found that you can remove line 53 in your "no_field_markup_clean_markup" function.

I attached a patch for this below:

Good luck!

moertle’s picture

moertle commented

ANDiTKO,
I updated the project with your inputs, thanks for this.

ruz’s picture

ruz commented

Hi,

The module worked as expected.
Code is well written. Nice work!

moertle’s picture

moertle commented
Issue tags: +PAreview: review bonus

I've reviewed 3 Projects:

http://drupal.org/node/1778760#comment-6499690
http://drupal.org/node/1783722#comment-6477566
http://drupal.org/node/1787780#comment-6491146

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

Thanks for your reviews, just make sure that you pick the oldest applications first.

Please add all your reviews to your issue summary, as outlined in http://drupal.org/node/1410826

manual review:

  1. The README should contain instructions where to configure your module and the field output.
  2. no_field_markup_preprocess_field(): you could remove one if() by using !empty()
  3. This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

Thanks for your contribution, moertle!

I promoted this project for you. Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Git Repo Link updated