Comments

weebpal’s picture

Status: Needs work » Needs review

Dear Drupal community,

We would like to submit the first product that we developed here. Please help us review and give us some suggest to improve this product and give us permission to be able to share more.

Thanks and Best Regards,
WeebPal

klausi’s picture

Status: Needs review » Needs work

Please note: All user accounts are for individuals. Accounts created for more than one user or those using anonymous mail services will be blocked when discovered.

Please change your user name and account accordingly.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

weebpal’s picture

Status: Needs review » Needs work

Hi Klausi,

I'm sorry because I don't know this rule. I've just update account and name but I can't update email so please agree me keep this account!.

About review I'm trying to review other projects now,

Thanks,
Steve Jan

weebpal’s picture

Status: Needs work » Needs review
weebpal’s picture

Issue tags: +PAreview: review bonus

Add PAReview: review bonus tag

klausi’s picture

Status: Needs review » Needs work
Issue tags: -PAreview: review bonus

manual review:

  1. the project page of iShoping should only describe the theme. Same for your other projects. Project pages are important for users to quickly find out if it matches their needs. Please remove the company advertisement, you can of course give credit in one or two lines and link to your company's homepage. See also http://drupal.org/node/997024
  2. Same for the README.txt files, they should contain an actual description about the project.
  3. fonts/oswald: appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.

The code looks good otherwise. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

klausi’s picture

Issue summary: View changes

Add review other projects links

weebpal’s picture

Issue summary: View changes

- update detail

weebpal’s picture

Issue summary: View changes

update issue detail

weebpal’s picture

Issue summary: View changes

- update project detail

weebpal’s picture

Issue summary: View changes

- udpate issue detail

weebpal’s picture

Status: Needs work » Needs review
Issue tags: +PAreview: review bonus

Hi Klausi,

Thanks for your comments and I've fixed all of them. Please help me review this project and give me some suggestion to make this project become better.

Thanks,
Steve Jan

klausi’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus

Ok, looks RTBC to me! Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

klausi’s picture

Issue summary: View changes

- add Review Other Projects

weebpal’s picture

Issue tags: +PAreview: review bonus

Dear Klausi,

Thanks for your review my project quickly, I'd like to add PAReview: review bonus tag and hope that you will approve my project become the full project.

Thanks and Best Regards,
Steve Jan

klausi’s picture

Status: Reviewed & tested by the community » Fixed

no objections for more than a week, so ...

Thanks for your contribution, Steve Jan!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

weebpal’s picture

Dear Klausi,

Thank you very much for your help. We'll try that we can contribute more useful products to our community.

Thanks & Best Regards,
Steve Jan

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

- Add review other projects