Comments

r2integrated’s picture

Unable to clone 7.x-2.x branch. Received the following:

(1:2028)$ git clone --recursive --branch master http://git.drupal.org/sandbox/nguerrero/1846714.git ie_must_die
Cloning into 'ie_must_die'...
remote: Counting objects: 23, done.
remote: Compressing objects: 100% (23/23), done.
remote: Total 23 (delta 12), reused 0 (delta 0)
Unpacking objects: 100% (23/23), done.
warning: Remote branch master not found in upstream origin, using HEAD instead
warning: remote HEAD refers to nonexistent ref, unable to checkout.
r2integrated’s picture

Status: Needs review » Needs work

Needs work.

nesta_’s picture

Status: Needs work » Needs review

branch master if not exist, you can clone git clone --recursive --branch 7.x-2.x http://git.drupal.org/sandbox/nguerrero/1846714.git ie_must_die

gazoakley’s picture

Status: Needs review » Needs work

I don't think there's enough code to review here:

Code too short
This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

I'm not sure what the process is for promoting a single project - but even then there's only 1 actual line of code and that's not even in a hook. The install module is empty of any actual code.

nesta_’s picture

Status: Needs work » Needs review

I already know, but for this functionality there is more to do.

The module has the line of death in css for IE and not can get you much more.

To view code and see that I am still the standard programming and Drupal, you can watch the following module which I also checked it me.

Thanks a lot.

http://drupal.org/node/1846248 Views_styles.

gazoakley’s picture

Status: Needs review » Closed (duplicate)

Hi nguerrero,

It appears that there have been multiple project applications opened under your username:

views_styles: http://drupal.org/node/1846248
ie_must_die: http://drupal.org/node/1846732

As successful completion of the project application process results in the applicant being granted the ´Create Full Projects´ permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as ´closed(duplicate)´, with only the oldest application left open.

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the ´open´ application as a duplicate, and re-open one of the project applications which had been closed.

gazoakley’s picture

Issue summary: View changes

update drupal 7

avpaderno’s picture

Issue summary: View changes
Related issues: +#1846248: views_styles