This module will add a drag drop type of question in quiz module.
By using this module admin can upload images with their titles and later on all titles will become placeholder. User need to drag and drop images on the correct placeholder to get points. Currently we don't have this type of question in quiz module in drupal.
Project Page Link : http://drupal.org/sandbox/npscode/1888166
Git Repository Link : git clone --recursive --branch 7.x-1.x npscode@git.drupal.org:sandbox/npscode/1888166.git quiz_drag_drop
Non-maintainer : git clone http://git.drupal.org/sandbox/npscode/1888166.git quiz_drag_drop
This module is for Drupal 7.
Reviews of other projects:
http://drupal.org/node/1913606#comment-7051834
http://drupal.org/node/1913916#comment-7051892
http://drupal.org/node/1910316#comment-7053624
Some more manual reviews done by me:
https://drupal.org/node/1918758#comment-7072766
https://drupal.org/node/1917624#comment-7072874
https://drupal.org/node/1918832#comment-7073046
Comment | File | Size | Author |
---|---|---|---|
#15 | coder-results.txt | 1.15 KB | klausi |
#4 | drag_drop_quiz.png | 32.69 KB | brunodbo |
Comments
Comment #1
brunodboThanks for posting your module!
Some comments after a manual review:
I also ran your module through PAReview, which lists all the code style issues, and a few other ones, see http://ventral.org/pareview/httpgitdrupalorgsandboxnpscode1888166git for the report. You can re-run the review after you've made changes, to verify your progress.
Comment #2
npscode CreditAttribution: npscode commentedHi brunodbo,
Thanks for reviewing my module.
As per your suggestion i have done all the changes required and created 7.x-1.x branch.
I have removed all the coding style related issues except few in "quiz_drag_drop.classes.inc", since my module uses quiz module's api/classes to introduce a new drag drop type of question. i am bound to follow these structure/functions otherwise my module will not work.
Other than this i have fixed every issues you pointed out.
Comment #3
npscode CreditAttribution: npscode commentedKindly review the code again.. thanks..
Comment #4
brunodboI noticed some things in theme_quiz_drag_drop_answer_form():
In quiz_drag_drop_uninstall(): would it be possible to remove quiz_drag_drop nodes when uninstalling the module?
Some typos:
I enabled the module on a fresh D7 installation and created a quiz with a drag and drop question. It works well (and drag and drop questions are fun! :)).
I'm getting a number of PHP warnings when I navigate to a quiz with drag and drop questions (didn't investigate where these are coming from though, they might be coming from the main quiz.module):
Comment #5
brunodboOops, wrong status.
Comment #6
npscode CreditAttribution: npscode commentedThanks for all the suggestions. Did all the changes mentioned by you..
PHP warnings are coming from quiz module itself.. :)
Kindly do the review..
Comment #7
klausiWe are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)
Comment #8
vladimir-m CreditAttribution: vladimir-m commentedHello
Thank you for great module.
Manual review:
1. Please add git link corresponding to non-maintainer like "git clone http://git.drupal.org/sandbox/npscode/1888166.git quiz_drag_drop"
2. In file: quiz_drag_drop.install at line: 19 variable "node_options_quiz_drag_drop" is set, for what you set this variable? If variable is set you have to delete them in hook_uninstall().
Comment #9
npscode CreditAttribution: npscode commentedHi vladimir-m,
I will take care of the second point mentioned by you but can you please explain first point. should i add git link "git clone http://git.drupal.org/sandbox/npscode/1888166.git quiz_drag_drop" in my project issue summary??
Thanks..
Comment #10
npscode CreditAttribution: npscode commentedHi vladimir-m,
I have done all the changes mentioned by you. Kindly review the code again.
Thanks.
Comment #11
jurcello CreditAttribution: jurcello commentedFunctionality review:
I created a quiz question containing 4 images. On Chrome for OSX I was unable to drag a portrait picture to the matching box. It turned out that the image was to big for the box. Setting the tolerance option on line 19 of the javascript from fit to intersect solved the problem. Is there a reason that you used fit here?
Code review:
The code looks ok at first sight. I got some coding standard issues regarding whitespaces found at end of line, so maybe it is a good idea to check again, but this should not hold promotion.
This is a nice little module!
Comment #12
npscode CreditAttribution: npscode commentedHi jurcello,
I deliberately used fit there as i want user to drag and drop the image completely on the placeholder.
Let me know if you are not able to drop the image on the placeholder?
Comment #13
npscode CreditAttribution: npscode commentedComment #13.0
npscode CreditAttribution: npscode commentedAdded non-maintainer like "git clone http://git.drupal.org/sandbox/npscode/1888166.git quiz_drag_drop" as per suggestion..
Comment #14
npscode CreditAttribution: npscode commentedAdded other projects reviews done. Kindly review the module now.
Comment #15
klausiReview of the 7.x-1.x branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
manual review:
Otherwise looks pretty ready, pushing back to "needs work" as you need to know when to sanitize user input and what it is good for. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.
Comment #15.0
klausiAdded reviews of other projects done.
Comment #16
npscode CreditAttribution: npscode commentedHi klausi,
I have worked on all the points that you mentioned and fixed all the issues.
I have done another 3 reviews of other projects. so adding "PAReview: review bonus" tag again. Kindly do the review now.
I hope we can make it a full project now. :-)
Thanks..
Comment #17
npscode CreditAttribution: npscode commentedI have done another 3 reviews of other projects. so adding "PAReview: review bonus" tag.
Comment #18
klausimanual review:
Otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.
Assigning to cubeinspire as he might have time to finally approve this.
Comment #19
jthorson CreditAttribution: jthorson commentedThanks for your contribution, npscode!
I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #20.0
(not verified) CreditAttribution: commentedadded review links.