Authorpane Popup

welcome,

As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also make sure your README.txt follows the guidelines for in-project documentation.

It appears you are working in the "7.x.1.x-dev" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxarun1940782git

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

edit1

Thanks for your participation, but I'm afraid the comments you did are not very detailed and IMHO not really "reviews".
A good deep review can take up to an hour, this is not about just pointing out 1 or 2 things and set the issues to needs work.
Sorry, removing tag.

For more detail please go here http://drupal.org/node/1410826

Hi

Manual Review

In your module js file add drupal js behaviour.

Thanks
Mayank Kamothi

Hi Arun

You have missed to add @file block in JS and CSS file.

1. You should mention on the project page that Author_pane is required: http://drupal.org/sandbox/ARUN/1940782
See Tips for a great project page

2. There is author_pane_popup.git folder. I guess it has been commited by mistake. What about removing it?

3. I've installed the module. When I hover over author name, the black cicle appears (Firefox 19.0.2). It takes some time to retrieve popup content. So if user does not know that popup is going to appear, he moves mouse out of the author name and never sees the popup. What about adding some loader or text hint to let user know that something is going to happen and he/she should wait for a while and not to move mouse cursor outside of the author name.

Projects reviewed so far added.

manual review:

1. project page is too short, see http://drupal.org/node/997024
2. author_pane_popup_init(): why do you add you add JS and CSS globally in hook_init()? That will be executed on every single page request even if no author pane is shown?
3. author_pane_popup_menu(): the page callback is unprotected. This should at least require the show user profiles permission. This is a security issue.
4. author_pane_popup_menu(): Use "%user" instead of "%" and the user object will be auto loaded for you.
5. author_pane_popup_preprocess_node(): It seems like this hook is a good place to add your JS and CSS.
6. author_pane_popup_preprocess_node(): why is the strp_tags() call needed? The l() function will run check_plain() anyway for you?

The module is pretty short and this sounds like a feature that should live in the existing author_pane project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the author_pane issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

Please don't remove the security tag, we keep that for statistics and to show examples of security problems.

What about including this directly into author_pane, did you already contact the maintainer and open an issue?

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

branch corrected

Thanks for opening the issue! I think you should provide a patch against the module and the maintainer does not seem to opposed against it.

ADDED MORE REVIEWS LINKS

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.