[D7] PM Vista

So... you just extracted theme from a pm module?

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Ran 'git clone' inside fresh install ( d7.22 - and 4/413 rev PM) and didn't work so good. See Attached. Screenshot is using Chrome as web broser - testing for responsive theme design. Responsive attributes appear functional, but not 100% sure of that.

For starters your background styling in the header should have repeat instead of no-repeat for people who have larger monitors or else it looks like screenshot1. #edit-search-block-form--2 should have width 100% instead of a static width. Consider looking at the theme on tablets and add more media queries in order to fix your layouts' responsiveness, you can see what I'm talking about in screenshots 2,3 and 4.

@D34dMan - Was away from computer most of today. I've an app loaded into Chrome that lets you check the various screen devices. My problem was that I did not think about PM_Vista having a dependency on Omega. When I downloaded and enabled Omega (with Drush) then it worked fine and looked like your demo.

The theme really looks great. When it gets down to iPhone size the text overwrites the images.

Thanks for your help.

Added review list.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: #1962038: [D7] PM Vista
Project 2: #1309746: [D6] Storm Organization Holiday Manager

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/template.php
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 4 WARNING(S) AFFECTING 4 LINE(S)
  --------------------------------------------------------------------------------
   135 | WARNING | Code after RETURN statement cannot be executed
   136 | WARNING | Code after RETURN statement cannot be executed
   138 | WARNING | Code after RETURN statement cannot be executed
   139 | WARNING | Code after RETURN statement cannot be executed
  --------------------------------------------------------------------------------
  
  Time: 1 second, Memory: 15.75Mb
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. Omega 3.x is not the latest version, so you should mention that omega 3.x is required for your theme, not omega 4.x.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to Dave Reid as he might have time to take a final look at this.

added link to project

I think there might be a conflict with the admin_menu module. I enabled the PM module and your theme and my admin bar has disappeared.

Tested the subtheme here on a local install without PM, no problems viewing the admin menu. Screenshot in attach.

@nsuit I've downloaded and installed Drupal 7.22 using the standard profile along with Omega 3.1, Administration menu 3.0 rc4 and PM_Vista, but there were no such issues defined by you, can you please explain us what steps you've made that have produced such issue? I'm attaching a Screenshot by me for reference.

Since it was made RTBC before in #14 (http://drupal.org/node/1962038#comment-7265210) and issue in #17 (http://drupal.org/node/1962038#comment-7281098) cannot be reproduced, I am changing it back to RTBC.

no other objections for more than a week, so ...

Thanks for your contribution, D34dMan!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.