This module uses direct database manipulation instead of using user_save, so other modules like Role Change Notify cannot interoperate with it (see #341126: Does not work with Role Delegation). user_save() is the preferred way to operate.

The attached patch updates role_delegation to use user_save().

CommentFileSizeAuthor
#2 role_delegation_user_save_patch_drupal5.patch1.07 KBrfay

Comments

nathan573’s picture

nathan573 commented

Is this patch available, or is it under review? There is no attached file.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
StatusFileSize
new role_delegation_user_save_patch_drupal5.patch1.07 KB

Interesting... I attached it to the issue and it doesn't show. Here it is.

marcp’s picture

marcp commented

I haven't tested the patch yet, but agree that this is the correct way to save roles. It's how Userplus does things now when assigning roles after having a similar issue raised.

nathan573’s picture

nathan573 commented

I applied this patch on a production site and it seems to work properly.

iamwhoiam’s picture

iamwhoiam commented
Status: Needs review » Reviewed & tested by the community

Definitely works. Please commit?

david lesieur’s picture

david lesieur commented
Version: 5.x-1.1 » 5.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.