Module should use user_save instead of directly accessing drupal database (drupal5 patch)
rfay - December 1, 2008 - 14:07
| Project: | Role Delegation |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
This module uses direct database manipulation instead of using user_save, so other modules like Role Change Notify cannot interoperate with it (see #341126: Does not work with Role Delegation). user_save() is the preferred way to operate.
The attached patch updates role_delegation to use user_save().
#1
Is this patch available, or is it under review? There is no attached file.
#2
Interesting... I attached it to the issue and it doesn't show. Here it is.
#3
I haven't tested the patch yet, but agree that this is the correct way to save roles. It's how Userplus does things now when assigning roles after having a similar issue raised.
#4
I applied this patch on a production site and it seems to work properly.
#5
Definitely works. Please commit?
#6
Committed, thanks!
#7
Automatically closed -- issue fixed for 2 weeks with no activity.