Download & Extend
Role Delegation » Issues

Module should use user_save instead of directly accessing drupal database (drupal5 patch)

Posted by rfay on December 1, 2008 at 2:07pm
Project:Role Delegation
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

This module uses direct database manipulation instead of using user_save, so other modules like Role Change Notify cannot interoperate with it (see #341126: Does not work with Role Delegation). user_save() is the preferred way to operate.

The attached patch updates role_delegation to use user_save().

Login or register to post comments

Comments

#1

Posted by nathan573 on December 4, 2008 at 9:37pm

Is this patch available, or is it under review? There is no attached file.

#2

Posted by rfay on December 4, 2008 at 9:46pm

Interesting... I attached it to the issue and it doesn't show. Here it is.

AttachmentSize
role_delegation_user_save_patch_drupal5.patch 1.07 KB

#3

Posted by marcp on December 7, 2008 at 3:10pm

I haven't tested the patch yet, but agree that this is the correct way to save roles. It's how Userplus does things now when assigning roles after having a similar issue raised.

#4

Posted by nathan573 on December 11, 2008 at 10:21pm

I applied this patch on a production site and it seems to work properly.

#5

Posted by iamwhoiam on February 26, 2009 at 12:36pm
Status:needs review» reviewed & tested by the community

Definitely works. Please commit?

#6

Posted by David Lesieur on March 3, 2009 at 1:15am
Version:5.x-1.1» 5.x-1.x-dev
Status:reviewed & tested by the community» fixed

Committed, thanks!

#7

Posted by System Message on March 17, 2009 at 1:20am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.